Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non_fmt_panic lint error in latest nightly #95

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Fix non_fmt_panic lint error in latest nightly #95

merged 1 commit into from
Feb 11, 2021

Conversation

lopopolo
Copy link
Contributor

See rust-lang/rust#81645, rust-lang/rust#81729.

Because this crate's public API is several macros, this lint does not get capped: the tokens are directly included in the local crate, which triggers the error.

Here's a failing workflow run on the latest nightly: https://github.com/artichoke/intaglio/runs/1867615715?check_suite_focus=true.

@mgeisler mgeisler merged commit 7756d66 into mgeisler:master Feb 11, 2021
@mgeisler
Copy link
Owner

Hi @lopopolo, thank you very much! I better setup a regular CI run so I can test the crate against nightly Rust.

mgeisler added a commit that referenced this pull request Feb 13, 2021
Together with a weekly CI run (#100), this should ensure that we catch
issues like #95 quickly when they appear on the nightly Rust channel.
@github-actions github-actions bot mentioned this pull request Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants