Rollup of 9 pull requests #77102
Merged
Rollup of 9 pull requests #77102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for Atomic::from_mut.
This reverts commit 5ef1db3.
Instead of a few hardcoded cfg(target_arch = ..) like before.
This was missed in PR rust-lang#75465. As a result, a few places have been using the full body span of functions, instead of just the header span.
I little clarification
Continuation of rust-lang#74526 Adds the #[track_caller] attribute to almost all panicking Cell functions. The ones that borrow two Cells in their function body are spared, because the panic location helps pinpoint which of the two borrows failed. You'd need to have full debuginfo and backtraces enabled together with column info in order to be able to discern the cases. Column info is only available on non-Windows platforms.
Co-authored-by: Ivan Tham <[email protected]>
Co-authored-by: Ivan Tham <[email protected]>
Record `tcx.def_span` instead of `item.span` in crate metadata This was missed in PR rust-lang#75465. As a result, a few places have been using the full body span of functions, instead of just the header span.
emit errors during AbstractConst building There changes are currently still untested, so I don't expect this to pass CI 😆 It seems to me like this is the direction we want to go in, though we didn't have too much of a discussion about this. r? @oli-obk
…-from-mut, r=Amanieu Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut. Fixes some platform-specific problems with rust-lang#74532 by using the actual alignment of the types instead of hardcoding a few `target_arch`s. r? @RalfJung
Changing the alloc() to accept &self instead of &mut self Fixes: [rust-lang#55](rust-lang/wg-allocators#55) This is the first cut. It only makes the change for `alloc` method.
fix small typo in docs and comments Fixed `the the` to `the`, as far as I found.
…-iter, r=Dylan-DPC Add missing examples on Vec iter types r? @Dylan-DPC
Improve documentation for ToSocketAddrs I little clarification
Miri: more informative deallocation error messages Make sure we show the affected AllocId. r? @oli-obk
…ulacrum Add #[track_caller] to more panicking Cell functions Continuation of rust-lang#74526 Adds the #[track_caller] attribute to almost all panicking Cell functions. The ones that borrow two Cells in their function body are spared, because the panic location helps pinpoint which of the two borrows failed. You'd need to have full debuginfo and backtraces enabled together with column info in order to be able to discern the cases. Column info in debuginfo is only available on non-Windows platforms.
|
@bors r+ rollup |
|
📌 Commit c3c03f2 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors rollup=never :P |
|
☀️ Test successful - checks-actions, checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Sep 24, 2020
Tested on commit rust-lang/rust@c351775. Direct link to PR: <rust-lang/rust#77102> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
This was referenced Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tcx.def_spaninstead ofitem.spanin crate metadata #76898 (Recordtcx.def_spaninstead ofitem.spanin crate metadata)Failed merges:
r? @ghost