Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for ToSocketAddrs #77042

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Improve documentation for ToSocketAddrs #77042

merged 3 commits into from
Sep 24, 2020

Conversation

imbolc
Copy link
Contributor

@imbolc imbolc commented Sep 22, 2020

I little clarification

@imbolc
Update addr.rs
2a40b63 
I little clarification
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2020
@jyn514 jyn514 changed the title Update addr.rs Improve documentation for ToSocketAddrs Sep 22, 2020
@jyn514 jyn514 added A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 22, 2020
@kennytm
Copy link
Member

kennytm commented Sep 22, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 22, 2020

📌 Commit 4622ceb has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2020
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Sep 22, 2020
@ecstatic-morse
Rollup merge of rust-lang#77042 - imbolc:patch-2, r=kennytm
cff8489 
Improve documentation for ToSocketAddrs

I little clarification
@ecstatic-morse ecstatic-morse mentioned this pull request Sep 22, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2020
@bors
Auto merge of rust-lang#77102 - Dylan-DPC:rollup-2jfrg3u, r=Dylan-DPC
c351775 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#76898 (Record `tcx.def_span` instead of `item.span` in crate metadata)
 - rust-lang#76939 (emit errors during AbstractConst building)
 - rust-lang#76965 (Add cfg(target_has_atomic_equal_alignment) and use it for Atomic::from_mut.)
 - rust-lang#76993 (Changing the alloc() to accept &self instead of &mut self)
 - rust-lang#76994 (fix small typo in docs and comments)
 - rust-lang#77017 (Add missing examples on Vec iter types)
 - rust-lang#77042 (Improve documentation for ToSocketAddrs)
 - rust-lang#77047 (Miri: more informative deallocation error messages)
 - rust-lang#77055 (Add #[track_caller] to more panicking Cell functions)

Failed merges:

r? `@ghost`
@bors bors merged commit 049ba0c into rust-lang:master Sep 24, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire left review comments

Assignees

@kennytm kennytm

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
7 participants
@imbolc @rust-highfive @kennytm @bors @pickfire @jyn514 @rustbot