Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint missing docs for extern items #77032

Merged
merged 1 commit into from
Sep 22, 2020
Merged

lint missing docs for extern items #77032

merged 1 commit into from
Sep 22, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 21, 2020

fixes #76991

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2020
@lcnr lcnr mentioned this pull request Sep 21, 2020
Closed
@lcnr
Copy link
Contributor Author

lcnr commented Sep 21, 2020

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned eddyb Sep 21, 2020
@lcnr lcnr force-pushed the visit-all-the-item-likes branch from 235c95a to d452744 Compare September 21, 2020 22:03
davidtwco
davidtwco approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 21, 2020

📌 Commit d452744 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2020
@dboyce-gh
Copy link

Where is check_foreign_item() called?

@jyn514 jyn514 added the A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. label Sep 22, 2020
@tesuji
Copy link
Contributor

tesuji commented Sep 22, 2020

Where is check_foreign_item() called?

It is always called, just that's the default implementation on LateLintPass is empty, now it is overridden.

@ecstatic-morse ecstatic-morse mentioned this pull request Sep 22, 2020
Merged
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Sep 22, 2020
@ecstatic-morse
Rollup merge of rust-lang#77032 - lcnr:visit-all-the-item-likes, r=da…
e146fcf 
…vidtwco

lint missing docs for extern items

fixes rust-lang#76991
@ecstatic-morse ecstatic-morse mentioned this pull request Sep 22, 2020
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2020
@bors
Auto merge of rust-lang#77039 - ecstatic-morse:rollup-qv3jj4a, r=ecst…
c2bc344 
…atic-morse

Rollup of 13 pull requests

Successful merges:

 - rust-lang#72734 (Reduce duplicate in liballoc reserve error handling)
 - rust-lang#76131 (Don't use `zip` to compare iterators during pretty-print hack)
 - rust-lang#76150 (Don't recommend ManuallyDrop to customize drop order)
 - rust-lang#76275 (Implementation of Write for some immutable ref structs)
 - rust-lang#76489 (Add explanation for E0756)
 - rust-lang#76581 (do not ICE on bound variables, return `TooGeneric` instead)
 - rust-lang#76655 (Make some methods of `Pin` unstable const)
 - rust-lang#76783 (Only get ImplKind::Impl once)
 - rust-lang#76807 (Use const-checking to forbid use of unstable features in const-stable functions)
 - rust-lang#76888 (use if let instead of single match arm expressions)
 - rust-lang#76914 (extend `Ty` and `TyCtxt` lints to self types)
 - rust-lang#77022 (Reduce boilerplate for BytePos and CharPos)
 - rust-lang#77032 (lint missing docs for extern items)

Failed merges:

r? `@ghost`
@bors bors merged commit 0863f9a into rust-lang:master Sep 22, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

warn(missing_docs) doesn't trigger on extern declarations
9 participants
@lcnr @rust-highfive @davidtwco @bors @dboyce-gh @tesuji @eddyb @jyn514 @rustbot