Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn(missing_docs) doesn't trigger on extern declarations #76991

Closed
Lokathor opened this issue Sep 21, 2020 · 3 comments · Fixed by #77032
Closed

warn(missing_docs) doesn't trigger on extern declarations #76991

Lokathor opened this issue Sep 21, 2020 · 3 comments · Fixed by #77032
Assignees
@lcnr
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Lokathor
Copy link
Contributor

Lokathor commented Sep 21, 2020 •
edited by rustbot
Loading

playground example

It seems like this lint should fire if you have an extern declaration without docs on it.
@camelid

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2020
@lcnr
Copy link
Contributor

lcnr commented Sep 21, 2020 •
edited
Loading

I think I know what causes this and will write a more general fix here this week.

@rustbot claim

@lcnr lcnr mentioned this issue Sep 21, 2020
Merged
@lcnr
Copy link
Contributor

lcnr commented Sep 21, 2020

the fix wasn't more general but it's a fix none the less #77032

ecstatic-morse added a commit to ecstatic-morse/rust that referenced this issue Sep 22, 2020
@ecstatic-morse
Rollup merge of rust-lang#77032 - lcnr:visit-all-the-item-likes, r=da…
e146fcf 
…vidtwco

lint missing docs for extern items

fixes rust-lang#76991
@bors bors closed this as completed in 0863f9a Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcnr lcnr

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lint missing docs for extern items lcnr/rust
4 participants
@Lokathor @lcnr @camelid @rustbot