Rollup of 10 pull requests #75999
Closed
Rollup of 10 pull requests #75999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a false positive for transparent newtype with a non-zero member.
Co-authored-by: Bastian Kauschke <[email protected]>
Expand rustdoc theme chooser x padding   But I still think there is room for improvement considering mdbook.  CC @GuillaumeGomez @jyn514
…declarations-transparent-nonzero, r=lcnr Fix another clashing_extern_declarations false positive. Fixes rust-lang#75739. Fix another clashing_extern_declarations false positive, this time for transparent newtype with a non-zero member. r? @lcnr
…_typo, r=petrochenkov Fix typo in TLS Model in Unstable Book
…er-background-color, r=pickfire Improve theme button hover background color Fixes rust-lang#75880.   r? @pickfire
Add test for issue rust-lang#27130 rust-lang#27130 seems to be fixed by the llvm 11 update. The issue is marked with needs-test, so here it is. As some historical context, the generated code was fine until 1.38, and remained unoptimized from 1.38 up until the current nightly. I've also added a pattern matching version that was fine on 1.45.2.
…, r=jyn514 Move to intra doc links for core::ptr::non_null Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc r? @jyn514
…r=ehuss Fix typo (`thumbv8m.main-none-eabihf` is Mainline)
Fix typo in release notes
Improve help popup Fixes rust-lang#75623. The second commit is just a slight improvement: the help popup won't be created until someone presses "?" or ESC. Not a big improvement in itself but considering the low amount of code required, I think it was worth the shot. r? @jyn514
Should not apply field accessing on enum Closes rust-lang#75977 But I'm surprised that `x.py test --stage 1` and CI didn't catch this with existing testcase. r? @estebank
|
@bors r+ rollup=never p=5 |
|
📌 Commit e23290f has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e23290f with merge f922f94dcb4092d91292eb86f66407f5f3e411c5... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
How do you access the logs for the failed build? |
|
https://github.com/rust-lang-ci/rust/runs/1038546677 Looks like it's caused by #75910 :/ |
|
failed in rollup |
|
@bors r- |
bors
added
S-waiting-on-author
|
@Dylan-DPC I think I fixed the issue, how should I proceed? |
|
i'll make a new rollup in a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
thumbv8m.main-none-eabihfis Mainline) #75919 (Fix typo (thumbv8m.main-none-eabihfis Mainline))Failed merges:
r? @ghost