Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theme button hover background color #75901

Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #75880.

Screenshot from 2020-08-25 13-44-01
Screenshot from 2020-08-25 13-43-43

r? @pickfire

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better but still not so visible.

@GuillaumeGomez
Copy link
Member Author

Surprisingly it's quite visible when you're hovering and all. I prefer not to change the color too much for now though. Might be interesting to make another pass later on.

@bors: r=pickfire rollup

@bors
Copy link
Contributor

bors commented Aug 25, 2020

📌 Commit f20f7f2 has been approved by pickfire

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 25, 2020
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc labels Aug 25, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 27, 2020
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 28, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Aug 29, 2020
@bors
Copy link
Contributor

bors commented Aug 30, 2020

⌛ Testing commit f20f7f2 with merge 99b4a01...

@bors
Copy link
Contributor

bors commented Aug 30, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: pickfire
Pushing 99b4a01 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 30, 2020
@bors bors merged commit 99b4a01 into rust-lang:master Aug 30, 2020
@GuillaumeGomez GuillaumeGomez deleted the ayu-theme-button-hover-background-color branch August 30, 2020 09:22
@cuviper cuviper added this to the 1.48.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ayu theme hover not noticible
5 participants