Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x #74639
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
r? @cuviper (but seems fine to me) |
|
Looks fine, but I'm going to test these builds myself before approving. This doesn't actually include ppc64le though -- that's a separate builder based on CentOS 7 headers for glibc 2.17 and kernel 3.10. Upstream glibc didn't actually support ppc64le until 2.19, but Red Hat backported it. It looks like SUSE added ppc64le support in SLES 12, glibc 2.19 and kernel 3.12, right? So I think that target is fine anyway. Perhaps you just meant to write "ppc64(be)"? Meaning that big-endian is implied for ppc64... |
msirringhaus
changed the title
|
Whoops, yes you are correct about |
|
@bors r+ |
|
📌 Commit e46219c has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e46219c with merge 0f4b86960d6d15ea0ae6f4fdf1a21657c4a976bc... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e46219c with merge 1f0ed71a2bf64b4971878af46a5e0b41dbf2cae0... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Same -- I'll try again later. |
|
@bors retry |
|
@ehuss is this a known/ongoing issue? |
|
Yep, working on a fix now, closed the tree in the meantime. |
Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x As discussed in rust-lang#73782 I've tested these changes on rust 1.43.0 for all the specified archs and used the resulting binaries to bootstrap building rust 1.43.1. I've also shortly tested these changes on master on ppc64.
…arth Rollup of 8 pull requests Successful merges: - rust-lang#72954 (revise RwLock for HermitCore) - rust-lang#74367 (Rearrange the pipeline of `pow` to gain efficiency) - rust-lang#74491 (Optimize away BitAnd and BitOr when possible) - rust-lang#74639 (Downgrade glibc to 2.11.1 for ppc, ppc64 and s390x) - rust-lang#74661 (Refactor `region_name`: add `RegionNameHighlight`) - rust-lang#74692 (delay_span_bug instead of silent ignore) - rust-lang#74698 (fixed error reporting for mismatched traits) - rust-lang#74715 (Add a system for creating diffs across multiple mir optimizations.) Failed merges: r? @ghost
As discussed in #73782
I've tested these changes on rust 1.43.0 for all the specified archs and used the resulting binaries to bootstrap building rust 1.43.1.
I've also shortly tested these changes on master on ppc64.