Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pretty/asm.rs should only be tested for x86_64 and not AArch64 #73308

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

yerke
Copy link
Contributor

@yerke yerke commented Jun 13, 2020

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes #73134
r? @Amanieu

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2020
@yerke yerke force-pushed the fix-pretty-asm-rs-test-for-aarch64 branch from 6eb9868 to 249a46f Compare June 13, 2020 07:41
@Amanieu
Copy link
Member

Amanieu commented Jun 13, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 13, 2020

📌 Commit 249a46f has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 13, 2020
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 13, 2020
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 13, 2020
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 13, 2020
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 13, 2020
…rch64, r=Amanieu

pretty/asm.rs should only be tested for x86_64 and not AArch64

pretty/asm.rs should only be tested for x86_64 and not AArch64
closes rust-lang#73134
r?  @Amanieu
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#72932 (Clarify the behaviour of Pattern when used with methods like str::contains)
 - rust-lang#73066 (Querify whether a type has structural equality (Take 2))
 - rust-lang#73194 (Prefer the associated constants for pattern matching error)
 - rust-lang#73241 (Add/update comments about MinGW late_link_args)
 - rust-lang#73267 (Use the built cargo for cargotest.)
 - rust-lang#73290 (Fix links when pinging notification groups)
 - rust-lang#73302 (Adjusted some doctests in libcore to use `should_panic`.)
 - rust-lang#73308 (pretty/asm.rs should only be tested for x86_64 and not AArch64)

Failed merges:

r? @ghost
@bors bors merged commit 8d97ccf into rust-lang:master Jun 13, 2020
@yerke yerke deleted the fix-pretty-asm-rs-test-for-aarch64 branch June 13, 2020 19:40
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pretty/asm.rs test is failing on AArch64
5 participants