Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer the associated constants for pattern matching error #73194

Merged
merged 1 commit into from
Jun 13, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 10, 2020

Resolved this comment: #68490 (comment)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2020
@tesuji tesuji changed the title Prefer the associated constants for error E0004 Prefer the associated constants for pattern matching error Jun 11, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jun 13, 2020

r? @dtolnay

@rust-highfive rust-highfive assigned dtolnay and unassigned estebank Jun 13, 2020
@dtolnay
Copy link
Member

dtolnay commented Jun 13, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 13, 2020

📌 Commit c755292 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#72932 (Clarify the behaviour of Pattern when used with methods like str::contains)
 - rust-lang#73066 (Querify whether a type has structural equality (Take 2))
 - rust-lang#73194 (Prefer the associated constants for pattern matching error)
 - rust-lang#73241 (Add/update comments about MinGW late_link_args)
 - rust-lang#73267 (Use the built cargo for cargotest.)
 - rust-lang#73290 (Fix links when pinging notification groups)
 - rust-lang#73302 (Adjusted some doctests in libcore to use `should_panic`.)
 - rust-lang#73308 (pretty/asm.rs should only be tested for x86_64 and not AArch64)

Failed merges:

r? @ghost
@bors bors merged commit f738423 into rust-lang:master Jun 13, 2020
@tesuji tesuji deleted the INT-patterns branch June 14, 2020 00:53
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants