Rollup of 12 pull requests #72716
Merged
Rollup of 12 pull requests #72716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also include the following changes: * Remove unused `hir::Map::as_local_node_id` method * Remove outdated comment about `hir::Map::local_def_id` method * Remove confusing `GlobMap` type alias * Use `LocalDefId` instead of `DefId` in `extern_crate_map` * Use `LocalDefId` instead of `DefId` in `maybe_unused_extern_crates` * Modify `extern_mod_stmt_cnum` query to accept a `LocalDefId` instead of a `DefId`
This just unwraps clippy's build step instead of skipping tests if clippy didn't build. This matches e.g. cargo's behavior and seems more correct, as we always expect clippy to successfully build.
In a recent change, 8b19922, adjustments were made to the data layout we pass to LLVM. Unfortunately, the illumos target was missed in this change. See also: rust-lang#67900
Implement PartialOrd and Ord for SocketAddr* The implementation is mostly the same as the one found in `IpAddr` (other than adding comparison for ports, of course). Continues rust-lang#53788 and rust-lang#53863 Fixes rust-lang#53710
Stabilize str_strip feature
This PR stabilizes these APIs:
```rust
impl str {
/// Returns a string slice with the prefix removed.
///
/// If the string starts with the pattern `prefix`, `Some` is returned with the substring where
/// the prefix is removed. Unlike `trim_start_matches`, this method removes the prefix exactly
/// once.
pub fn strip_prefix<'a, P: Pattern<'a>>(&'a self, prefix: P) -> Option<&'a str>;
/// Returns a string slice with the suffix removed.
///
/// If the string ends with the pattern `suffix`, `Some` is returned with the substring where
/// the suffix is removed. Unlike `trim_end_matches`, this method removes the suffix exactly
/// once.
pub fn strip_suffix<'a, P>(&'a self, suffix: P) -> Option<&'a str>
where
P: Pattern<'a>,
<P as Pattern<'a>>::Searcher: ReverseSearcher<'a>;
}
```
Closes rust-lang#67302
…an-DPC Add working example for E0617 explanation r? @Dylan-DPC
…, r=petrochenkov Cleanup `Resolver::<clone|into>_outputs` methods Follow-up cleanup work of rust-lang#72402 First commit has been split out from rust-lang#72552 r? @ecstatic-morse
Add myself to .mailmap
…matsakis expand unaligned_references test Also test implicit ref when having a field as a method receiver, as suggested by @bluss.
…r=nikomatsakis Fix incorrect comment in generator test rust-lang#69837 (comment) (thanks for the catch, @jplatte)
…pass, r=oli-obk Clippy should always build This just unwraps clippy's build step instead of skipping tests if clippy didn't build. This matches e.g. cargo's behavior and seems more correct, as we always expect clippy to successfully build. I believe this doesn't actually change anything in practice, but I feel mildly uncomfortable potentially leaving this hole open.
Add test for rust-lang#66930 Closes rust-lang#66930 Closes rust-lang#67558 They're fixed by rust-lang#72424. I skipped adding `--emit=mir` flag to src/test/ui/issues/issue-25145.rs as a regression test since the root cause seems the same and it should be run with `check-pass`, not `run-pass` so we should duplicate that test. r? @RalfJung
update data layout for illumos x86 In a recent change, 8b19922, adjustments were made to the data layout we pass to LLVM. Unfortunately, the illumos target was missed in this change. See also: rust-lang#67900
…omatsakis Remove rustc-ux-guidelines This is now in the rustc-dev-guide: * rust-lang/rustc-dev-guide#716 * rust-lang/rustc-dev-guide#717 This is a public page, but it was not linked to anywhere, so I think it is safe to remove. Google searches don't show it being used anywhere.
rustc_lint: Remove `unused_crate_dependencies` from the `unused` group Fixes rust-lang#72686 It's undesirable to enable `unused_crate_dependencies` with blanket `#![deny(unused)]` due to the amount of redundant `--extern` options passed by Cargo.
|
@bors r+ rollup=never p=12 |
|
📌 Commit 049b6dd has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Resolver::<clone|into>_outputsmethods #72636 (CleanupResolver::<clone|into>_outputsmethods)unused_crate_dependenciesfrom theunusedgroup #72702 (rustc_lint: Removeunused_crate_dependenciesfrom theunusedgroup)Failed merges:
r? @ghost