Skip to content

Commit

Permalink
Rollup merge of #72702 - petrochenkov:unudeps, r=estebank
Browse files Browse the repository at this point in the history
rustc_lint: Remove `unused_crate_dependencies` from the `unused` group

Fixes #72686

It's undesirable to enable `unused_crate_dependencies` with blanket `#![deny(unused)]` due to the amount of redundant `--extern` options passed by Cargo.
  • Loading branch information
Dylan-DPC authored May 29, 2020
2 parents ada9c11 + 1eef0c3 commit 049b6dd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/librustc_lint/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ fn register_builtins(store: &mut LintStore, no_interleave_lints: bool) {
UNUSED_ALLOCATION,
UNUSED_DOC_COMMENTS,
UNUSED_EXTERN_CRATES,
UNUSED_CRATE_DEPENDENCIES,
UNUSED_FEATURES,
UNUSED_LABELS,
UNUSED_PARENS,
Expand Down
9 changes: 9 additions & 0 deletions src/test/ui/unused-crate-deps/lint-group.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// `unused_crate_dependencies` is not currently in the `unused` group
// due to false positives from Cargo.

// check-pass
// aux-crate:bar=bar.rs

#![deny(unused)]

fn main() {}

0 comments on commit 049b6dd

Please sign in to comment.