-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #69990
Rollup of 7 pull requests #69990
Commits on Feb 25, 2020
-
Remove
sip::Hasher::short_write
.`sip::Hasher::short_write` is currently unused. It is called by `sip::Hasher::write_{u8,usize}`, but those methods are also unused, because `DefaultHasher`, `SipHasher` and `SipHasher13` don't implement any of the `write_xyz` methods, so all their write operations end up calling `sip::Hasher::write`. (I confirmed this by inserting a `panic!` in `sip::Hasher::short_write` and running the tests -- they all passed.) The alternative would be to add all the missing `write_xyz` methods. This does give some significant speed-ups, but it hurts compile times a little in some cases. See rust-lang#69152 for details. This commit does the conservative thing and doesn't change existing behaviour.
Configuration menu - View commit details
-
Copy full SHA for 54d1c50 - Browse repository at this point
Copy the full SHA 54d1c50View commit details
Commits on Mar 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3ba89e8 - Browse repository at this point
Copy the full SHA 3ba89e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for db75b6a - Browse repository at this point
Copy the full SHA db75b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f1ca87 - Browse repository at this point
Copy the full SHA 1f1ca87View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9cc010 - Browse repository at this point
Copy the full SHA a9cc010View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33600e4 - Browse repository at this point
Copy the full SHA 33600e4View commit details -
Write backtrace fmt test using relative paths
For some reason the absolute paths were formatted differently on the armhf-gnu target. thread '<unnamed>' panicked at 'assertion failed: `(left == right)` left: `"Backtrace [\n { fn: \"__rust_maybe_catch_panic\" },\n { fn: \"std::rt::lang_start_internal\", file: \"./rust/rt.rs\", line: 300 },\n { fn: \"std::rt::lang_start\", file: \"./rust/rt.rs\", line: 400 },\n]"`, right: `"Backtrace [\n { fn: \"__rust_maybe_catch_panic\" },\n { fn: \"std::rt::lang_start_internal\", file: \"/rust/rt.rs\", line: 300 },\n { fn: \"std::rt::lang_start\", file: \"/rust/rt.rs\", line: 400 },\n]"`', src/libstd/backtrace.rs:486:5
Configuration menu - View commit details
-
Copy full SHA for a2364dc - Browse repository at this point
Copy the full SHA a2364dcView commit details
Commits on Mar 11, 2020
-
Compute the correct layout for variants of uninhabited enums and read…
…d a long lost assertion This reverts part of commit 9712fa4.
Configuration menu - View commit details
-
Copy full SHA for cdc7304 - Browse repository at this point
Copy the full SHA cdc7304View commit details -
Co-Authored-By: Ralf Jung <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ec88ffa - Browse repository at this point
Copy the full SHA ec88ffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74608c7 - Browse repository at this point
Copy the full SHA 74608c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 543832b - Browse repository at this point
Copy the full SHA 543832bView commit details
Commits on Mar 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7995a08 - Browse repository at this point
Copy the full SHA 7995a08View commit details
Commits on Mar 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 40ffcc2 - Browse repository at this point
Copy the full SHA 40ffcc2View commit details -
Fix abort-on-eprintln during process shutdown
This commit fixes an issue where if `eprintln!` is used in a TLS destructor it can accidentally cause the process to abort. TLS destructors are executed after `main` returns on the main thread, and at this point we've also deinitialized global `Lazy` values like those which store the `Stderr` and `Stdout` internals. This means that despite handling TLS not being accessible in `eprintln!`, we will fail due to not being able to call `stderr()`. This means that we'll double-panic quickly because panicking also attempt to write to stderr. The fix here is to reimplement the global stderr handle to avoid the need for destruction. This avoids the need for `Lazy` as well as the hidden panic inside of the `stderr` function. Overall this should improve the robustness of printing errors and/or panics in weird situations, since the `stderr` accessor should be infallible in more situations.
Configuration menu - View commit details
-
Copy full SHA for c274e07 - Browse repository at this point
Copy the full SHA c274e07View commit details
Commits on Mar 14, 2020
-
Rollup merge of rust-lang#69122 - dtolnay:backtrace, r=cramertj
Backtrace Debug tweaks - Change Debug representation of disabled and unsupported backtraces to use \<placeholder\> style, same as what we do for debug printing locked mutexes and mutably borrowed refcells; ```diff - Error { msg: "...", backtrace: disabled backtrace } + Error { msg: "...", backtrace: <disabled> } ``` - Remove quotes around unresolved symbol names; ```diff - Backtrace [{ fn: "<unknown>" }] + Backtrace [{ fn: <unknown> }] ``` - Add quotes around file paths; ```diff - Backtrace [{ fn: "krate::main", file: /path/to/main.rs, line: 10 }] + Backtrace [{ fn: "krate::main", file: "/path/to/main.rs", line: 10 }] ``` - Add test.
Configuration menu - View commit details
-
Copy full SHA for 570edd0 - Browse repository at this point
Copy the full SHA 570edd0View commit details -
Rollup merge of rust-lang#69471 - nnethercote:rm-sip-Hasher-short_wri…
…te, r=dtolnay Remove `sip::Hasher::short_write`. `sip::Hasher::short_write` is currently unused. It is called by `sip::Hasher::write_{u8,usize}`, but those methods are also unused, because `DefaultHasher`, `SipHasher` and `SipHasher13` don't implement any of the `write_xyz` methods, so all their write operations end up calling `sip::Hasher::write`. (I confirmed this by inserting a `panic!` in `sip::Hasher::short_write` and running the tests -- they all passed.) The alternative would be to add all the missing `write_xyz` methods. This does give some significant speed-ups, but it hurts compile times a little in some cases. See rust-lang#69152 for details. This commit does the conservative thing and doesn't change existing behaviour. r? @rust-lang/libs
Configuration menu - View commit details
-
Copy full SHA for f8756ac - Browse repository at this point
Copy the full SHA f8756acView commit details -
Rollup merge of rust-lang#69768 - oli-obk:union_field_ice, r=eddyb,Ra…
…lfJung Compute the correct layout for variants of uninhabited enums r? @eddyb cc @RalfJung fixes rust-lang#69191 cc rust-lang#69763
Configuration menu - View commit details
-
Copy full SHA for 8f06c62 - Browse repository at this point
Copy the full SHA 8f06c62View commit details -
Rollup merge of rust-lang#69929 - cuviper:unicode-13.0.0, r=Mark-Simu…
…lacrum Regenerate tables for Unicode 13.0.0
Configuration menu - View commit details
-
Copy full SHA for af0cdbf - Browse repository at this point
Copy the full SHA af0cdbfView commit details -
Rollup merge of rust-lang#69942 - estebank:sized-verbose-sugg, r=matt…
…hewjasper Increase verbosity when suggesting subtle code changes Do not suggest changes that are actually quite small inline, to minimize the likelihood of confusion. Fix rust-lang#69243.
Configuration menu - View commit details
-
Copy full SHA for b8d85a3 - Browse repository at this point
Copy the full SHA b8d85a3View commit details -
Rollup merge of rust-lang#69955 - alexcrichton:stderr-infallible, r=s…
…fackler Fix abort-on-eprintln during process shutdown This commit fixes an issue where if `eprintln!` is used in a TLS destructor it can accidentally cause the process to abort. TLS destructors are executed after `main` returns on the main thread, and at this point we've also deinitialized global `Lazy` values like those which store the `Stderr` and `Stdout` internals. This means that despite handling TLS not being accessible in `eprintln!`, we will fail due to not being able to call `stderr()`. This means that we'll double-panic quickly because panicking also attempt to write to stderr. The fix here is to reimplement the global stderr handle to avoid the need for destruction. This avoids the need for `Lazy` as well as the hidden panic inside of the `stderr` function. Overall this should improve the robustness of printing errors and/or panics in weird situations, since the `stderr` accessor should be infallible in more situations.
Configuration menu - View commit details
-
Copy full SHA for 6c44885 - Browse repository at this point
Copy the full SHA 6c44885View commit details -
Rollup merge of rust-lang#69987 - kraai:mailmap, r=nikomatsakis
Add self to .mailmap The variants are only used for [rust-lang/rust-clippy](https://github.com/rust-lang/rust-clippy), but it seems like <https://thanks.rust-lang.org/> only uses this `.mailmap`.
Configuration menu - View commit details
-
Copy full SHA for 9771fdf - Browse repository at this point
Copy the full SHA 9771fdfView commit details