Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point at try ? on errors affecting the err match arm of the desugared code #60064

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

estebank
Copy link
Contributor

Fix #59980.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2019
@estebank
Copy link
Contributor Author

r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned pnkfelix Apr 18, 2019
@varkor
Copy link
Member

varkor commented Apr 18, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit 1e99b2e has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
Point at try `?` on errors affecting the err match arm of the desugared code

Fix rust-lang#59980.
bors added a commit that referenced this pull request Apr 19, 2019
Rollup of 16 pull requests

Successful merges:

 - #59915 (Implement event filtering for self-profiler.)
 - #59933 (Make clear that format padding doesn't work for Debug)
 - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate)
 - #60032 (Remove unwanted z-index change)
 - #60041 (Simplify the returning of a Result a bit)
 - #60045 (Suggest appropriate path when calling associated item on bare types)
 - #60052 (Correct unused parameter diagnostic)
 - #60056 (Update rustfmt to 1.2.1)
 - #60060 (whitelist RTM x86 target cpu feature)
 - #60061 (Change suggestion of field when not in self context)
 - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code)
 - #60078 (Use more realistic example for thread builder)
 - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.)
 - #60082 (Update miri)
 - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8)
 - #60098 (libcore: deny `elided_lifetimes_in_paths`)

Failed merges:

r? @ghost
@bors bors merged commit 1e99b2e into rust-lang:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E277 could have a more helpful error message when it occurs on a try expression
5 participants