Implement event filtering for self-profiler. #59915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
Apr 12, 2019
[WIP] Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from #59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-author
wesleywiser
reviewed
Apr 12, 2019
|
@bors try |
bors
added a commit
that referenced
this pull request
Apr 12, 2019
[WIP] Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from #59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
wesleywiser
force-pushed
the
sp-event-filters-1
branch
from
cb7be41
to
10b43bb
Compare
|
@michaelwoerister I rebased your branch on top of #59515 which I've updated to use @bors try |
bors
added a commit
that referenced
this pull request
Apr 13, 2019
[WIP] Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from #59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
☀️ Try build successful - checks-travis |
|
@rust-timer build 30ce132 |
|
Success: Queued 30ce132 with parent 99da733, comparison URL. |
|
Finished benchmarking try commit 30ce132 |
|
Wow, that actually seems pretty good! |
|
Yeah, that looks like a good start. |
michaelwoerister
force-pushed
the
sp-event-filters-1
branch
from
10b43bb
to
9900f3f
Compare
|
@bors try |
|
⌛ Trying commit 9900f3fbb201ce10804b84d571af520450e9f239 with merge 4dd3271ce58c3080ddcc1bf21df704efad2b73c1... |
|
☀️ Try build successful - checks-travis |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 18, 2019
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 18, 2019
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 18, 2019
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
⌛ Testing commit 08efbac with merge 9ae856c4d802aed5c1663a6837b69ed3c39853f5... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
@bors retry |
|
⌛ Testing commit 08efbac with merge c9e8a274f30eadd5a3cae0069d922e75e67bee8d... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
@bors retry |
|
⌛ Testing commit 08efbac with merge 271c8cfeca93e207e6be4d475ff15c9409f66917... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 19, 2019
…, r=wesleywiser Implement event filtering for self-profiler. This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from rust-lang#59515 and, for the moment, is meant for performance testing. r? @wesleywiser
|
@bors retry |
bors
added a commit
that referenced
this pull request
Apr 19, 2019
Rollup of 16 pull requests Successful merges: - #59915 (Implement event filtering for self-profiler.) - #59933 (Make clear that format padding doesn't work for Debug) - #60023 (implement specialized nth_back() for Bytes, Fuse and Enumerate) - #60032 (Remove unwanted z-index change) - #60041 (Simplify the returning of a Result a bit) - #60045 (Suggest appropriate path when calling associated item on bare types) - #60052 (Correct unused parameter diagnostic) - #60056 (Update rustfmt to 1.2.1) - #60060 (whitelist RTM x86 target cpu feature) - #60061 (Change suggestion of field when not in self context) - #60064 (Point at try `?` on errors affecting the err match arm of the desugared code) - #60078 (Use more realistic example for thread builder) - #60080 (Fix small errors in docs for `rchunks_exact` and `rchunks_exact_mut`.) - #60082 (Update miri) - #60097 (Use -mergefunc-use-aliases for any LLVM >= 8) - #60098 (libcore: deny `elided_lifetimes_in_paths`) Failed merges: r? @ghost
27 tasks
marieell
reviewed
Feb 6, 2022
| EVENT_FILTERS_BY_NAME.iter() | ||
| .map(|&(name, _)| name.to_string()) | ||
| .collect::<Vec<_>>() | ||
| .join(", ")); |
There was a problem hiding this comment.
I think this warrants being an error instead of just a warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first sketch for event filtering in the self-profiler, something that we'll want in order to keep profiling overhead low in the common case. The PR contains the commits from #59515 and, for the moment, is meant for performance testing.
r? @wesleywiser