Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include mode in unused binding suggestion span #59993

Merged
merged 1 commit into from
Apr 16, 2019
Merged

include mode in unused binding suggestion span #59993

merged 1 commit into from
Apr 16, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Apr 15, 2019

Fixes #54180.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2019
@estebank
Copy link
Contributor

@bors r+ r=estebank rollup

@bors
Copy link
Contributor

bors commented Apr 15, 2019

📌 Commit 74560f3 has been approved by estebank

@bors
Copy link
Contributor

bors commented Apr 15, 2019

💡 This pull request was already approved, no need to approve it again.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2019
@bors
Copy link
Contributor

bors commented Apr 15, 2019

📌 Commit 74560f3 has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Apr 16, 2019
@Centril
Rollup merge of rust-lang#59993 - euclio:unused-ref-field, r=estebank
4e68fe8 
include mode in unused binding suggestion span

Fixes rust-lang#54180.
@Centril Centril mentioned this pull request Apr 16, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 16, 2019
@Centril
Rollup merge of rust-lang#59993 - euclio:unused-ref-field, r=estebank
a95ca29 
include mode in unused binding suggestion span

Fixes rust-lang#54180.
@Centril Centril mentioned this pull request Apr 16, 2019
Merged
bors added a commit that referenced this pull request Apr 16, 2019
@bors
Auto merge of #60007 - Centril:rollup-gdh1er4, r=Centril
a7cef0b 
Rollup of 6 pull requests

Successful merges:

 - #59717 (improve docs for std::hint::unreachable_unchecked())
 - #59903 (Continue evaluating after missing main)
 - #59973 (Fix rustdoc sidebar z-index)
 - #59992 (rustdoc: use --static-root-path for settings.js)
 - #59993 (include mode in unused binding suggestion span)
 - #60000 (Add repo-specific triagebot configuration)

Failed merges:

r? @ghost
@bors bors merged commit 74560f3 into rust-lang:master Apr 16, 2019
@euclio euclio deleted the unused-ref-field branch April 16, 2019 14:44
@sapir sapir mentioned this pull request Dec 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler suggests invalid code with ref pattern
5 participants
@euclio @rust-highfive @estebank @bors @cramertj