-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
include mode in unused binding suggestion span
- Loading branch information
Showing
4 changed files
with
119 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// run-rustfix | ||
|
||
#![deny(unused)] | ||
|
||
pub struct S { | ||
pub f1: i32, | ||
} | ||
|
||
pub struct Point { | ||
pub x: i32, | ||
pub y: i32, | ||
} | ||
|
||
pub enum E { | ||
Variant { field: String } | ||
} | ||
|
||
pub fn foo(arg: &E) { | ||
match arg { | ||
E::Variant { field: _ } => (), //~ ERROR unused variable | ||
} | ||
} | ||
|
||
fn main() { | ||
let s = S { f1: 123 }; | ||
let S { f1: _ } = s; //~ ERROR unused variable | ||
|
||
let points = vec![Point { x: 1, y: 2 }]; | ||
let _: i32 = points.iter().map(|Point { x: _, y }| y).sum(); //~ ERROR unused variable | ||
|
||
match (Point { x: 1, y: 2 }) { | ||
Point { y, x: _ } => y, //~ ERROR unused variable | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// run-rustfix | ||
|
||
#![deny(unused)] | ||
|
||
pub struct S { | ||
pub f1: i32, | ||
} | ||
|
||
pub struct Point { | ||
pub x: i32, | ||
pub y: i32, | ||
} | ||
|
||
pub enum E { | ||
Variant { field: String } | ||
} | ||
|
||
pub fn foo(arg: &E) { | ||
match arg { | ||
E::Variant { ref field } => (), //~ ERROR unused variable | ||
} | ||
} | ||
|
||
fn main() { | ||
let s = S { f1: 123 }; | ||
let S { ref f1 } = s; //~ ERROR unused variable | ||
|
||
let points = vec![Point { x: 1, y: 2 }]; | ||
let _: i32 = points.iter().map(|Point { x, y }| y).sum(); //~ ERROR unused variable | ||
|
||
match (Point { x: 1, y: 2 }) { | ||
Point { y, ref mut x } => y, //~ ERROR unused variable | ||
}; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
error: unused variable: `field` | ||
--> $DIR/issue-54180-unused-ref-field.rs:20:26 | ||
| | ||
LL | E::Variant { ref field } => (), | ||
| ----^^^^^ | ||
| | | ||
| help: try ignoring the field: `field: _` | ||
| | ||
note: lint level defined here | ||
--> $DIR/issue-54180-unused-ref-field.rs:3:9 | ||
| | ||
LL | #![deny(unused)] | ||
| ^^^^^^ | ||
= note: #[deny(unused_variables)] implied by #[deny(unused)] | ||
|
||
error: unused variable: `x` | ||
--> $DIR/issue-54180-unused-ref-field.rs:29:45 | ||
| | ||
LL | let _: i32 = points.iter().map(|Point { x, y }| y).sum(); | ||
| ^ help: try ignoring the field: `x: _` | ||
|
||
error: unused variable: `f1` | ||
--> $DIR/issue-54180-unused-ref-field.rs:26:17 | ||
| | ||
LL | let S { ref f1 } = s; | ||
| ----^^ | ||
| | | ||
| help: try ignoring the field: `f1: _` | ||
|
||
error: unused variable: `x` | ||
--> $DIR/issue-54180-unused-ref-field.rs:32:28 | ||
| | ||
LL | Point { y, ref mut x } => y, | ||
| --------^ | ||
| | | ||
| help: try ignoring the field: `x: _` | ||
|
||
error: aborting due to 4 previous errors | ||
|