-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #59636
Rollup of 4 pull requests #59636
Commits on Mar 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a2b6734 - Browse repository at this point
Copy the full SHA a2b6734View commit details
Commits on Mar 29, 2019
-
Added documentation on the remainder (Rem) operator for floating points.
Christian committedMar 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 8fe1087 - Browse repository at this point
Copy the full SHA 8fe1087View commit details
Commits on Mar 30, 2019
-
Added an example that shows how the remainder function on floating po…
…int values is computed internally.
Christian committedMar 30, 2019 Configuration menu - View commit details
-
Copy full SHA for ea369cb - Browse repository at this point
Copy the full SHA ea369cbView commit details
Commits on Mar 31, 2019
-
Uses relative libdir to place libraries on all stages. Adds verbose installation output.
Configuration menu - View commit details
-
Copy full SHA for 5bcc365 - Browse repository at this point
Copy the full SHA 5bcc365View commit details
Commits on Apr 1, 2019
-
Fix stack overflow when generating debuginfo for 'recursive' type
By using 'impl trait', it's possible to create a self-referential type as follows: fn foo() -> impl Copy { foo } This is a function which returns itself. Normally, the signature of this function would be impossible to write - it would look like 'fn foo() -> fn() -> fn() ...' e.g. a function which returns a function, which returns a function... Using 'impl trait' allows us to avoid writing this infinitely long type. While it's useless for practical purposes, it does compile and run However, issues arise when we try to generate llvm debuginfo for such a type. All 'impl trait' types (e.g. ty::Opaque) are resolved when we generate debuginfo, which can lead to us recursing back to the original 'fn' type when we try to process its return type. To resolve this, I've modified debuginfo generation to account for these kinds of weird types. Unfortunately, there's no 'correct' debuginfo that we can generate - 'impl trait' does not exist in debuginfo, and this kind of recursive type is impossible to directly represent. To ensure that we emit *something*, this commit emits dummy debuginfo/type names whenever it encounters a self-reference. In practice, this should never happen - it's just to ensure that we can emit some kind of debuginfo, even if it's not particularly meaningful Fixes rust-lang#58463
Configuration menu - View commit details
-
Copy full SHA for 512069f - Browse repository at this point
Copy the full SHA 512069fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1837a0 - Browse repository at this point
Copy the full SHA e1837a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for aed7ec4 - Browse repository at this point
Copy the full SHA aed7ec4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4556a5 - Browse repository at this point
Copy the full SHA c4556a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2584e3 - Browse repository at this point
Copy the full SHA d2584e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for c13daeb - Browse repository at this point
Copy the full SHA c13daebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ccd35c - Browse repository at this point
Copy the full SHA 3ccd35cView commit details -
Improved the example with numbers that can be exactly represented as …
…floats and added a comment with the solution.
Christian committedApr 1, 2019 Configuration menu - View commit details
-
Copy full SHA for a1c7905 - Browse repository at this point
Copy the full SHA a1c7905View commit details
Commits on Apr 2, 2019
-
Rollup merge of rust-lang#59166 - seanmonstar:trait-alias-import, r=a…
…lexreg resolve: collect trait aliases along with traits It seems trait aliases weren't being collected as `TraitCandidates` in resolve, this should change that. (I can't compile the full compiler locally, so relying on CI...) Fixes rust-lang#56485 r? @alexreg
Configuration menu - View commit details
-
Copy full SHA for a2f3f0c - Browse repository at this point
Copy the full SHA a2f3f0cView commit details -
Rollup merge of rust-lang#59341 - o01eg:use-custom-libdir, r=Mark-Sim…
…ulacrum Fix custom relative libdir While working on rust-lang#58947 I found out relative libdir ignored during setting LD_LIBRARY_PATH.
Configuration menu - View commit details
-
Copy full SHA for 6bd01ef - Browse repository at this point
Copy the full SHA 6bd01efView commit details -
Rollup merge of rust-lang#59446 - Aaron1011:fix/debuginfo-overflow, r…
…=oli-obk Fix stack overflow when generating debuginfo for 'recursive' type By using 'impl trait', it's possible to create a self-referential type as follows: fn foo() -> impl Copy { foo } This is a function which returns itself. Normally, the signature of this function would be impossible to write - it would look like 'fn foo() -> fn() -> fn() ...' e.g. a function which returns a function, which returns a function... Using 'impl trait' allows us to avoid writing this infinitely long type. While it's useless for practical purposes, it does compile and run However, issues arise when we try to generate llvm debuginfo for such a type. All 'impl trait' types (e.g. ty::Opaque) are resolved when we generate debuginfo, which can lead to us recursing back to the original 'fn' type when we try to process its return type. To resolve this, I've modified debuginfo generation to account for these kinds of weird types. Unfortunately, there's no 'correct' debuginfo that we can generate - 'impl trait' does not exist in debuginfo, and this kind of recursive type is impossible to directly represent. To ensure that we emit *something*, this commit emits dummy debuginfo/type names whenever it encounters a self-reference. In practice, this should never happen - it's just to ensure that we can emit some kind of debuginfo, even if it's not particularly meaningful Fixes rust-lang#58463
Configuration menu - View commit details
-
Copy full SHA for 57a4f17 - Browse repository at this point
Copy the full SHA 57a4f17View commit details -
Rollup merge of rust-lang#59529 - DevQps:improve-rem-docs, r=cuviper
Added documentation on the remainder (Rem) operator for floating points. # Description As has been explained in rust-lang#57738 the remainder operator on floating points is not clear. This PR requests adds some information on how the `Rem` / remainder operator on floating points works. Note also that this description is for both `Rem<f32> for f32` and `Rem<f64> for f64` implementations. Ps. I wasn't really sure on how to formulate things. So please suggest changes if you have better idea's! closes rust-lang#57738
Configuration menu - View commit details
-
Copy full SHA for 21e2e98 - Browse repository at this point
Copy the full SHA 21e2e98View commit details