Account for short-hand field syntax when suggesting borrow #59455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @davidtwco |
Centril
reviewed
Mar 27, 2019
estebank
force-pushed
the
borrow-sugg-shorthand-field
branch
from
6bafb91 to
b67af6a
Compare
estebank
force-pushed
the
borrow-sugg-shorthand-field
branch
from
b67af6a to
07857f7
Compare
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Mar 29, 2019
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
borrow-sugg-shorthand-field
branch
from
2420173 to
9cbc640
Compare
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
borrow-sugg-shorthand-field
branch
from
9cbc640 to
ddfa47f
Compare
|
@bors r=davidtwco |
|
📌 Commit ddfa47f has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 29, 2019
…d, r=davidtwco Account for short-hand field syntax when suggesting borrow Fix rust-lang#52965.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 30, 2019
…d, r=davidtwco Account for short-hand field syntax when suggesting borrow Fix rust-lang#52965.
bors
added a commit
that referenced
this pull request
Mar 30, 2019
Rollup of 10 pull requests Successful merges: - #59376 (RFC 2008: Enum Variants) - #59453 (Recover from parse error in tuple syntax) - #59455 (Account for short-hand field syntax when suggesting borrow) - #59499 (Fix broken download link in the armhf-gnu image) - #59512 (implement `AsRawFd` for stdio locks) - #59525 (Whitelist some rustc attrs) - #59528 (Improve the dbg! macro docs ) - #59532 (In doc examples, don't ignore read/write results) - #59534 (rustdoc: collapse blanket impls in the same way as normal impls) - #59537 (Fix OnceWith docstring.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #52965.