Improve io docs #5672
Closed
Improve io docs #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifetimes and globals are now the only two places static is used, and 'static isn't matched by this
It's nice to make unsafe stand out, but this way isn't correct because it highlights it in comments.
Closes rust-lang#3549 The issue report has some reasoning, but I'd like to add that I don't think managed pointers belong in core. It's *possible* to write a safe doubly-linked list on top of `unsafe`, but it would be much more limited and I don't think there's much of a use case - it would lose a lot of flexibility. You're probably better off using a vector, hash table, tree, heap or ring buffer in almost every case.
rust-lang#5405 Also, renames the confusingly named `use_new_rt` in `libcore/unstable/lang.rs`
Added char_range_at_reverse underflow test
Fix typo and add fixed length vec changes.
Closes rust-lang#5643 This also removes the need to pass noexecstack to gcc, but that wasn't actually working anymore.
Fix typo and add fixed length vec changes.
There's no reason to make them executable, and this throws a warning with the Arch Linux package lint tool (namcap) for .a files.
There's no reason to make them executable, and this throws a warning with the Arch Linux package lint tool (namcap) for .a files.
Change fn() -> &fn().
Change fn() -> &fn().
Turns out @ isn't valid for the ARM assembler.
|
And then I continued to be an idiot. |
tesuji
pushed a commit
to tesuji/rustc
that referenced
this pull request
Jun 4, 2020
Add regression test for `string_lit_as_bytes` issue Closes rust-lang#5619 Before the fix in rust-lang#72637, `string_lit_as_bytes` was incorrectly triggering on the `env!` macro. With the fix merged, this test makes sure that the lint is not triggering anymore. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I submitted #5659, it apparently caused some test failures. Then, because I left it in my incoming rather than making a new branch, I deleted my commit.
Let's try this again, this time, with its own branch so that I don't screw it up.
r?