Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dlist to std #3549

Closed
brson opened this issue Sep 20, 2012 · 4 comments
Closed

Move dlist to std #3549

brson opened this issue Sep 20, 2012 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Sep 20, 2012

It's in core but has no users.
@graydon
Copy link
Contributor

graydon commented Sep 21, 2012

Agreed.

@bblum
Copy link
Contributor

bblum commented Sep 22, 2012

Yes, I had meant to do this.

@catamorphism
Copy link
Contributor

This is not so easy, due to iter-trait. (I'm not sure how to do the iter-trait hack cross-crate, or if we want to.) I propose considering this blocked on #2827, and thus bumping it to 0.6. In fact, I'm going to go ahead and do it.

@thestinger
Copy link
Contributor

iter-trait is gone so this would be as simple as a git mv and updating core.rc and std.rc now

@thestinger thestinger mentioned this issue Mar 30, 2013
Closed
bors added a commit that referenced this issue Mar 31, 2013
@bors
auto merge of #5634 : thestinger/rust/dlist, r=brson,thestinger
bd7ba1f 
Closes #3549

The issue report has some reasoning, but I'd like to add that I don't think managed pointers belong in core. It's *possible* to write a safe doubly-linked list on top of `unsafe`, but it would be much more limited and I don't think there's much of a use case - it would lose a lot of flexibility. You're probably better off using a vector, hash table, tree, heap or ring buffer in almost every case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@graydon @brson @catamorphism @thestinger @bblum