Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept .. in incorrect position to avoid further errors #51201

Merged
merged 3 commits into from
Jun 6, 2018
Merged

Accept .. in incorrect position to avoid further errors #51201

merged 3 commits into from
Jun 6, 2018

Commits on Jun 5, 2018

  1. Accept .. in incorrect position to avoid further errors 

    We currently give a specific message when encountering a `..` anywhere
other than the end of a pattern. Modify the parser to accept it (while
still emitting the error) so that we don't also trigger "missing fields
in pattern" errors afterwards.
    @estebank
    estebank committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    8f4a542 View commit details
    Browse the repository at this point in the history

  2. Improve diagnostics for incorrect .. usage 

    When using `..` somewhere other than the end, parse the rest of the
pattern correctly while still emitting an error.

Add suggestions to either remove trailing `,` or moving the `..` to the
end.
    @estebank
    estebank committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    cbc70a0 View commit details
    Browse the repository at this point in the history

  3. Account for comma in suggestion

    @estebank
    estebank committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    d66d35b View commit details
    Browse the repository at this point in the history