Accept .. in incorrect position to avoid further errors
#51201
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
src/libsyntax/parse/parser.rs
Outdated
| /// Parse the fields of a struct-like pattern | ||
| #[allow(unused_assignments)] |
There was a problem hiding this comment.
This should be avoidable.
There was a problem hiding this comment.
Leftover from a false positive in a previous iteration of the code.
| }); | ||
| ate_comma = self.eat(&token::Comma); |
There was a problem hiding this comment.
Usually after rewrites like this accidental mistakes happen and parser suddenly starts silently accept double commas or something like this, but I'd never notice it in a diff like this, so let's hope our test suite is good enough!
There was a problem hiding this comment.
I made a cursory test and the behavior when encountering multiple commas hasn't changed, the parser fails and no attempt at recovery is made.
|
r=me after fixing tidy |
estebank
force-pushed
the
dotdot
branch
2 times, most recently
from
8254f5f
to
2bdbc77
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors r=petrochenkov |
|
📌 Commit 78d82df has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
We currently give a specific message when encountering a `..` anywhere other than the end of a pattern. Modify the parser to accept it (while still emitting the error) so that we don't also trigger "missing fields in pattern" errors afterwards.
When using `..` somewhere other than the end, parse the rest of the pattern correctly while still emitting an error. Add suggestions to either remove trailing `,` or moving the `..` to the end.
|
@bors r=petrochenkov |
|
📌 Commit d66d35b has been approved by |
Accept `..` in incorrect position to avoid further errors We currently give a specific message when encountering a `..` anywhere other than the end of a pattern. Modify the parser to accept it (while still emitting the error) so that we don't also trigger "missing fields in pattern" errors afterwards. Add suggestions to either remove trailing `,` or moving the `..` to the end. Follow up to rust-lang#49268.
|
⌛ Testing commit d66d35b with merge eed6924b27375b8a6a2ee6c7454840e9a3a8aeb5... |
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors retry -- network error |
bors
added
S-waiting-on-bors
Accept `..` in incorrect position to avoid further errors We currently give a specific message when encountering a `..` anywhere other than the end of a pattern. Modify the parser to accept it (while still emitting the error) so that we don't also trigger "missing fields in pattern" errors afterwards. Add suggestions to either remove trailing `,` or moving the `..` to the end. Follow up to #49268.
|
☀️ Test successful - status-appveyor, status-travis |
We currently give a specific message when encountering a
..anywhereother than the end of a pattern. Modify the parser to accept it (while
still emitting the error) so that we don't also trigger "missing fields
in pattern" errors afterwards.
Add suggestions to either remove trailing
,or moving the..to theend.
Follow up to #49268.