Remove unstable `macro_reexport` #49982

petrochenkov · 2018-04-15T14:00:33Z

It's subsumed by feature(use_extern_macros) and pub use

rust-highfive · 2018-04-15T14:00:45Z

(rust_highfive has picked a reviewer for you, use r? to override)

TimNN

@petrochenkov: As far as I can tell with my limited knowledge of compiler internals, the changes look good.

Can you ping someone from the compiler team who is more familiar with this area of code, to give this a second look (otherwise I'll ping a random person from the team)?

TimNN · 2018-04-15T14:11:39Z

src/libstd/lib.rs


 #[macro_use]
-#[macro_reexport(vec, format)]


@petrochenkov: Just to confirm: the existing pub use alloc_crate::vec; below makes both, the module & macro, available?

TimNN · 2018-04-15T14:13:39Z

src/libstd/lib.rs

@@ -310,6 +309,7 @@
 #![feature(unboxed_closures)]
 #![feature(untagged_unions)]
 #![feature(unwind_attributes)]
+#![feature(use_extern_macros)]


@petrochenkov: How likely are the changes in this file to cause crates to break, e.g. because of an unknown compiler bug? Phrased differently, do you think a crater run would make sense?

I'd say unlikely.
If all local users of libstd like compiler and test suite build succesfully, then everything should be okay.

rust-highfive · 2018-04-15T15:11:23Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:49] configure: rust.quiet-tests     := True
---
[00:46:46] .................................................................................i..................
[00:46:53] ........................i...........................................................................
---
[00:47:35] ........................i...........................................................................
[00:47:41] i...................................................................................................
[00:47:48] ..............ii....................................................................................
---
[00:48:34] .............................................i......................................................
---
[00:52:30] ..............................i.....................................................................
[00:52:44] ...............................................................i....................................
[00:53:00] .................................................i..................................................
[00:53:20] ....................................................................................................
[00:53:41] ....................................................................................................
[00:54:03] ....................................................................................................
[00:54:28] .....i..............................................................................................
[00:54:56] .i...............................................................................test [run-pass] run-pass/mir_heavy_promoted.rs has been running for over 60 seconds
[00:55:05] ...................
[00:55:36] ....................................................................................................
[00:56:11] ...................................................................ii...............................
[00:56:58] ..............................i....................................................i.ii.test [run-pass] run-pass/saturating-float-casts.rs has been running for over 60 seconds
[00:57:04] ............
[00:57:47] ...........................................................................................iiiiiii..
---
[00:59:59] ...................i............................................................ii.iii..............
[01:00:06] ....................................................................................................
[01:00:15] ........i..............................i............................................................
[01:00:22] ....................................................................................................
[01:00:29] ..........i.........................................................................................
[01:00:37] ....................................................................................................
[01:00:47] ....................................................................................................
[01:00:57] ....................................................................................................
[01:01:08] ....................................................................................................
[01:01:21] ....................................................................................................
[01:01:29] ...i................................................................................................
[01:01:38] .i..ii..............................................................................................
[01:01:49] ....................................................................................................
[01:01:58] ....................................................................................................
[01:02:07] ...................................................................i................................
[01:02:18] .............i......................................................................................
---
[01:02:51] ...........................i........................................................................
[01:02:53] ....................................................................i...............................
[01:02:54] ................i.......................................................
---
[01:03:08] .............i........................
---
[01:03:38] i...i..ii....i.............ii.........iii......i..i...i...ii..i..i..ii.....
---
[01:03:41] i.......i......................i.......
---
[01:04:20] iiii.......i..i........i..i.i.............i..........iiii...........i...i..........ii.i.i.......ii..
[01:04:21] ....ii...
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:2ac11121:start=1523805080101202249,finish=1523805080115175381,duration=13973132
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:05ffa8f7
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:05ffa8f7:start=1523805080124210656,finish=1523805080134383991,duration=10173335
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2264b76c
$ dmesg | grep -i kill
[   10.606288] init: failsafe main process (1093) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2018-04-15T17:15:08Z

Actual failure:

[01:09:17] failures:
[01:09:17] 
[01:09:17] ---- [run-pass] run-pass-fulldeps/proc-macro/use-reexport.rs stdout ----
[01:09:17] 	
[01:09:17] error: aux-build `/checkout/src/test/run-pass-fulldeps/proc-macro/auxiliary/derive-reexport.rs` source not found
[01:09:17] thread '[run-pass] run-pass-fulldeps/proc-macro/use-reexport.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:1877:9
[01:09:17] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:09:17] 
[01:09:17] 
[01:09:17] failures:
[01:09:17]     [run-pass] run-pass-fulldeps/proc-macro/use-reexport.rs

petrochenkov · 2018-04-15T22:10:28Z

cc @rust-lang/lang
r? someone pursuing stabilization of use_extern_macros, e. g. @withoutboats

petrochenkov · 2018-04-15T22:12:06Z

src/test/ui/macro-reexport-removed.stderr

+error[E0557]: feature has been removed
+  --> $DIR/macro-reexport-removed.rs:13:12
+   |
+LL | #![feature(macro_reexport)] //~ ERROR feature has been removed


This should probably have some note about why the feature was removed and what should be used instead.

pietroalbini · 2018-04-23T12:02:34Z

Ping from triage @withoutboats! Can you review this PR?

cramertj · 2018-04-24T16:55:32Z

@pietroalbini I believe they're out this week.

r? @alexcrichton maybe?

alexcrichton · 2018-04-24T17:17:01Z

Thanks @petrochenkov! r=me once this is ready

petrochenkov · 2018-04-29T14:59:36Z

@bors r=alexcrichton

bors · 2018-04-29T14:59:37Z

📌 Commit 80712bb has been approved by alexcrichton

bors · 2018-04-29T18:41:04Z

⌛ Testing commit 80712bbce918960c05ca24fecd0cd1473524499c with merge db96ae2f636b18fab3b95d1f9db7edf848ca17f6...

bors · 2018-04-29T19:40:13Z

💔 Test failed - status-travis

petrochenkov · 2018-05-01T14:05:21Z

@bors r=alexcrichton

bors · 2018-05-01T14:05:22Z

📌 Commit 730c722 has been approved by alexcrichton

bors · 2018-05-01T16:12:18Z

⌛ Testing commit 730c722 with merge fe8480e9e740cf2e778143b6cacd01450a42cc2d...

bors · 2018-05-01T16:58:22Z

💔 Test failed - status-travis

rust-highfive · 2018-05-01T16:58:30Z

The job dist-x86_64-apple-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:49]       Memory: 8 GB
[00:02:49]       Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:02:49]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:02:49]       SMC Version (system): 2.8f0
[00:02:49]       Serial Number (system): VMqeZHX62eo+
[00:02:49] 
[00:02:49] hw.ncpu: 4
[00:02:49] hw.byteorder: 1234
[00:02:49] hw.memsize: 8589934592
---
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[00:40:49]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:40:49]                                  Dload  Upload   Total   Spent    Left  Speed
[00:40:49] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[00:40:49] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:525:17
[00:40:49] failed to run: /Users/travis/build/rust-lang/rust/build/bootstrap/debug/bootstrap build
[00:40:49] Build completed unsuccessfully in 0:35:29
[00:40:49] Build completed unsuccessfully in 0:35:29
[00:40:49] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:11f24250
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_fold:start:after_failure.2
travis_time:start:1951e9c9
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
total 0
drwx------+ 15 travis  staff  510 Jan 25 19:20 ..
drwx------   2 travis  staff   68 Dec  6 11:00 .
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:28c8e5aa
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
travis_time:end:28c8e5aa:start=1525193800439089000,finish=1525193800463789000,duration=24700000
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:069ea7d7
$ dmesg | grep -i kill
Unable to obtain kernel buffer: Operation not permitted
usage: sudo dmesg
travis_fold:end:after_failure.4

Done. Your build exited with 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

petrochenkov · 2018-05-01T17:14:16Z

Oh, come on.
@bors retry

bors · 2018-05-01T21:22:56Z

⌛ Testing commit 730c722 with merge 96b09e0...

Remove unstable `macro_reexport` It's subsumed by `feature(use_extern_macros)` and `pub use` cc #35896 closes #29638 closes #38951

bors · 2018-05-01T23:43:27Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 96b09e0 to master...

rust-highfive assigned TimNN Apr 15, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2018

petrochenkov mentioned this pull request Apr 15, 2018

Tracking issue for "macro naming and modularisation" (RFC #1561) #35896

Closed

TimNN reviewed Apr 15, 2018

View reviewed changes

petrochenkov assigned withoutboats and unassigned TimNN Apr 15, 2018

petrochenkov commented Apr 15, 2018

View reviewed changes

petrochenkov changed the title ~~Remove macro_reexport~~ Remove unstable macro_reexport Apr 16, 2018

rust-highfive assigned alexcrichton and unassigned withoutboats Apr 24, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2018

petrochenkov force-pushed the noreex branch from 19b5dcb to 80712bb Compare April 29, 2018 14:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2018

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2018

petrochenkov added 2 commits May 1, 2018 15:58

Give removal reasons to removed features

d98100b

Fix an error from "unused" lint + Fix rebase

730c722

petrochenkov force-pushed the noreex branch from 5278342 to 730c722 Compare May 1, 2018 14:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 1, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 1, 2018

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2018

bors added a commit that referenced this pull request May 1, 2018

Auto merge of #49982 - petrochenkov:noreex, r=alexcrichton

96b09e0

Remove unstable `macro_reexport` It's subsumed by `feature(use_extern_macros)` and `pub use` cc #35896 closes #29638 closes #38951

bors merged commit 730c722 into rust-lang:master May 1, 2018

messense mentioned this pull request May 2, 2018

Compile with stable Rust rwf2/Rocket#19

Closed

11 tasks

maxdeviant mentioned this pull request May 3, 2018

Replace macro_reexport with pub use rwf2/Rocket#624

Closed

tim3z mentioned this pull request May 3, 2018

rocket_contrib does not compile on latest nightly (8a37c75a3 2018-05-02) rwf2/Rocket#625

Closed

denysvitali mentioned this pull request May 3, 2018

Build failing: macro_reexport has been removed rwf2/Rocket#626

Closed

kennytm mentioned this pull request May 6, 2018

Spurious SIGILL (signal 4) when executing git from bootstrap test on x86_64-apple #50483

Closed

softprops mentioned this pull request Sep 27, 2018

keep an eye on macro_reexport rfc softprops/lando#7

Closed

ehuss mentioned this pull request Mar 1, 2019

Update attribute documentation. rust-lang/reference#528

Merged

petrochenkov deleted the noreex branch June 5, 2019 16:05

jsha mentioned this pull request Oct 25, 2020

Update how we import json macro algesten/ureq#208

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unstable `macro_reexport` #49982

Remove unstable `macro_reexport` #49982

petrochenkov commented Apr 15, 2018

rust-highfive commented Apr 15, 2018

TimNN left a comment

TimNN Apr 15, 2018 •

edited

Loading

petrochenkov Apr 15, 2018

TimNN Apr 15, 2018

petrochenkov Apr 15, 2018

rust-highfive commented Apr 15, 2018

kennytm commented Apr 15, 2018

petrochenkov commented Apr 15, 2018

petrochenkov Apr 15, 2018

pietroalbini commented Apr 23, 2018

cramertj commented Apr 24, 2018

alexcrichton commented Apr 24, 2018

petrochenkov commented Apr 29, 2018

bors commented Apr 29, 2018

bors commented Apr 29, 2018

bors commented Apr 29, 2018

This comment has been minimized.

petrochenkov commented May 1, 2018

bors commented May 1, 2018

bors commented May 1, 2018

bors commented May 1, 2018

This comment has been minimized.

rust-highfive commented May 1, 2018

petrochenkov commented May 1, 2018

bors commented May 1, 2018

bors commented May 1, 2018

Remove unstable macro_reexport #49982

Remove unstable macro_reexport #49982

Conversation

petrochenkov commented Apr 15, 2018

rust-highfive commented Apr 15, 2018

TimNN left a comment

Choose a reason for hiding this comment

TimNN Apr 15, 2018 • edited Loading

Choose a reason for hiding this comment

petrochenkov Apr 15, 2018

Choose a reason for hiding this comment

TimNN Apr 15, 2018

Choose a reason for hiding this comment

petrochenkov Apr 15, 2018

Choose a reason for hiding this comment

rust-highfive commented Apr 15, 2018

kennytm commented Apr 15, 2018

petrochenkov commented Apr 15, 2018

petrochenkov Apr 15, 2018

Choose a reason for hiding this comment

pietroalbini commented Apr 23, 2018

cramertj commented Apr 24, 2018

alexcrichton commented Apr 24, 2018

petrochenkov commented Apr 29, 2018

bors commented Apr 29, 2018

bors commented Apr 29, 2018

bors commented Apr 29, 2018

This comment has been minimized.

petrochenkov commented May 1, 2018

bors commented May 1, 2018

bors commented May 1, 2018

bors commented May 1, 2018

This comment has been minimized.

rust-highfive commented May 1, 2018

petrochenkov commented May 1, 2018

bors commented May 1, 2018

bors commented May 1, 2018

Remove unstable `macro_reexport` #49982

Remove unstable `macro_reexport` #49982

TimNN Apr 15, 2018 •

edited

Loading