Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failing: macro_reexport has been removed #626

Closed
denysvitali opened this issue May 3, 2018 · 3 comments
Closed

Build failing: macro_reexport has been removed #626

denysvitali opened this issue May 3, 2018 · 3 comments
Labels
nightly breakage Breakage on the nightly channel only

Comments

@denysvitali
Copy link

With the latest Rust nightly Rocket build fails.

   Compiling rocket_contrib v0.3.9
error[E0557]: feature has been removed
 --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/rocket_contrib-0.3.9/src/lib.rs:1:12
  |
1 | #![feature(macro_reexport)]
  |            ^^^^^^^^^^^^^^
  |
note: subsumed by `#![feature(use_extern_macros)]` and `pub use`
 --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/rocket_contrib-0.3.9/src/lib.rs:1:12
  |
1 | #![feature(macro_reexport)]
  |            ^^^^^^^^^^^^^^

error[E0658]: The attribute `macro_reexport` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642)
  --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/rocket_contrib-0.3.9/src/lib.rs:47:30
   |
47 | #[cfg_attr(feature = "json", macro_reexport(json_internal))]
   |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: add #![feature(custom_attribute)] to the crate attributes to enable

error: aborting due to 2 previous errors

Some errors occurred: E0557, E0658.
For more information about an error, try `rustc --explain E0557`.
error: Could not compile `rocket_contrib`.
warning: build failed, waiting for other jobs to finish...
error: build failed

The problem is that macro_reexport feature has been removed (see rust-lang/rust#49982)

@denysvitali
Copy link
Author

There is already a PR available (#624) and #625 is tracking this aswell, but was closed before the PR has been merged.

@SergioBenitez
Copy link
Member

Fixed in v0.3.10. 🎉

@denysvitali
Copy link
Author

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nightly breakage Breakage on the nightly channel only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants