Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented a few more unstable feature gates. #45166

Merged
merged 4 commits into from
Oct 13, 2017
Merged

Documented a few more unstable feature gates. #45166

merged 4 commits into from
Oct 13, 2017

Conversation

tinaun
Copy link
Contributor

@tinaun tinaun commented Oct 10, 2017

unboxed closures, fn_traits, and OIBIT. hope these are decent!

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member 

[01:16:00] unstable-book/print.html:2083: broken link - unstable-book/library-features/fn-traits.md

[01:16:00] unstable-book/print.html:2546: broken link - unstable-book/language-features/unboxed-closures.md

[01:16:00] unstable-book/library-features/fn-traits.html:93: broken link - unstable-book/language-features/unboxed-closures.md

[01:16:00] unstable-book/language-features/unboxed-closures.html:93: broken link - unstable-book/library-features/fn-traits.md

r=me after the links get fixed. thank you!

@tinaun tinaun force-pushed the more_unstable_docs branch from d13d521 to 2867387 Compare October 10, 2017 21:08
@tinaun
Copy link
Contributor Author

tinaun commented Oct 10, 2017

r= @steveklabnik

@tinaun tinaun force-pushed the more_unstable_docs branch from 2867387 to 4c61078 Compare October 10, 2017 23:31
@tinaun tinaun force-pushed the more_unstable_docs branch from 4c61078 to d5ef9f9 Compare October 11, 2017 03:21
@kennytm
Copy link
Member

kennytm commented Oct 11, 2017

@bors r=steveklabnik rollup

@bors
Copy link
Contributor

bors commented Oct 11, 2017

📌 Commit d5ef9f9 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Oct 11, 2017

🌲 The tree is currently closed for pull requests below priority 2, this pull request will be tested once the tree is reopened

@kennytm kennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 11, 2017
@kennytm
Rollup merge of rust-lang#45166 - tinaun:more_unstable_docs, r=stevek…
1faf129 
…labnik

Documented a few more unstable feature gates.

unboxed closures, fn_traits, and OIBIT. hope these are decent!
@kennytm kennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge of rust-lang#45166 - tinaun:more_unstable_docs, r=stevek…
5d25e1e 
…labnik

Documented a few more unstable feature gates.

unboxed closures, fn_traits, and OIBIT. hope these are decent!
@kennytm kennytm mentioned this pull request Oct 12, 2017
Merged
@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge of rust-lang#45166 - tinaun:more_unstable_docs, r=stevek…
7640cda 
…labnik

Documented a few more unstable feature gates.

unboxed closures, fn_traits, and OIBIT. hope these are decent!
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=<try>
6f8b325 
[WIP] Rollup of 10 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231
- Failed merges: #45138
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=kennytm
64ee7d1 
Rollup of 9 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45166, #45172, #45190, #45231
- Failed merges: #45138
@bors bors merged commit d5ef9f9 into rust-lang:master Oct 13, 2017
@tinaun tinaun deleted the more_unstable_docs branch January 23, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tinaun @rust-highfive @steveklabnik @kennytm @bors @aidanhs @GuillaumeGomez