-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jemalloc to 5.0.1 #45163
Upgrade jemalloc to 5.0.1 #45163
Conversation
Ok, so it looks like requiring autoconf is a problem. I've pushed an extra commit de-ignoring the config file and check it in. |
@bors: r+ |
📌 Commit e684700 has been approved by |
⌛ Testing commit e684700ce294fbc26e8a92768201f9968a2bf55f with merge 2d9a88b19fc83655778c7a4ea2d8c9106c4cb362... |
💔 Test failed - status-travis |
@bors retry |
⌛ Testing commit e684700ce294fbc26e8a92768201f9968a2bf55f with merge a6847a179074e0533cb52ec9d2651bc724870aa7... |
💔 Test failed - status-travis |
There is no O_CLOEXEC?
|
We build dists on a version of Linux from before CLOEXEC was created. Jemalloc's dev branch has a patch to deal with this but it's not in 5.0.1: jemalloc/jemalloc@0975b88. Hopefully it applies cleanly. |
@bors retry |
@bors r=alexcrichton |
📌 Commit 4f65e18 has been approved by |
@bors r- Build failed on
|
@bors try |
⌛ Trying commit 1b576406f6506d0849f7f98097d7ea3ecd2750ae with merge a1559cfb4c9081f1911cb70385a14083c144e93c... |
💔 Test failed - status-travis |
@bors try |
Upgrade jemalloc to 5.0.1 The build script needs to run autoconf which should be fine, right? We're building against 5.0.1 with jemalloc/jemalloc@0a4f5a7 cherry-picked on top. r? @alexcrichton
@bors r=alexcrichton |
📌 Commit 648e44f has been approved by |
Looks like this still have issues on Android, causing the compiled program sometimes segfault. Travis logs: |
Grr, ok thanks. |
I'm going to close this since I don't really want to figure out how to get the Android setup working. |
The build script needs to run autoconf which should be fine, right?
We're building against 5.0.1 with jemalloc/jemalloc@0a4f5a7 cherry-picked on top.
r? @alexcrichton