Rollup of 15 pull requests #44936
Closed
Rollup of 15 pull requests #44936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag removes all build artifacts, including the LLVM build directory.
This includes the following stabilizations: - tcpstream_connect_timeout rust-lang#44563 - iterator_for_each rust-lang#44567 - ord_max_min rust-lang#44593 - compiler_fences rust-lang#44595 - needs_drop rust-lang#44639 - vec_splice rust-lang#44640
No other iterator makes the distinction between an iterator and an iterator adapter in its summary line, so change it to be consistent with all other adapters.
That kind of formatting seems like the job of other code.
NetBSD doesn't ship with sha256sum. The openssl build will probably try to use perl anyway, so using perl's shasum is reasonable.
Some tar(1) programs—such as NetBSD's—do not automatically decompress.
* Change the context into the disabled directory. Now you can test containers which are disabled.
adding E0623 for return types - both parameters are anonymous This is a fix for rust-lang#44018 ``` error[E0621]: explicit lifetime required in the type of `self` --> $DIR/ex3-both-anon-regions-return-type-is-anon.rs:17:5 | 16 | fn foo<'a>(&self, x: &i32) -> &i32 { | ---- ---- | | | this parameter and the return type are declared with different lifetimes... 17 | x | ^ ...but data from `x` is returned here error: aborting due to previous error ``` It also works for the below case where we have self as anonymous ``` error[E0623]: lifetime mismatch --> src/test/ui/lifetime-errors/ex3-both-anon-regions-self-is-anon.rs:17:19 | 16 | fn foo<'a>(&self, x: &Foo) -> &Foo { | ---- ---- | | | this parameter and the return type are declared with different lifetimes... 17 | if true { x } else { self } | ^ ...but data from `x` is returned here error: aborting due to previous error ``` r? @nikomatsakis Currently, I have enabled E0621 where return type and self are anonymous, hence WIP.
|
💔 Test failed - status-appveyor |
bors
added a commit
that referenced
this pull request
Sep 30, 2017
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Sep 30, 2017
|
@bors retry |
|
Was this already pushed to master? |
|
Yes, actually. Closing. |
|
@bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T: 'xoutlives requirements on structs #44493 #44708, Add doc example to HashMap::hasher #44794, docs improvement std::sync::{PoisonError, TryLockError} #44797, Backport libs stabilizations to 1.21 beta #44824, Add missing links in fmt module #44836, Improve wording for StepBy #44840, Move src/librustc_mir/transform/nll.rs to a subdirectory #44845, docs improvement sync::atomic::Atomic* #44854, Remove DepNodeIndex::new is already impl for Idx #44889, Normalize spaces in lang attributes. #44900, ci: Fix building disabled containers #44903