Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs improvement std::sync::{PoisonError, TryLockError} #44797

Closed
wants to merge 1 commit into from
Closed

docs improvement std::sync::{PoisonError, TryLockError} #44797

wants to merge 1 commit into from

Conversation

lorepozo
Copy link
Contributor

Addresses the PoisonError and TryLockError parts of #29377.
Adds examples and links.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member

this looks great, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 24, 2017

📌 Commit 99c0c52 has been approved by frewsxcv

@carols10cents carols10cents added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 25, 2017
@lorepozo lorepozo closed this Sep 25, 2017
@lorepozo
Copy link
Contributor Author

Whoops, I force-pushed to my branch to work on other changes before this was merged in (so GitHub automatically closed this PR). I assume bors will still include the commit in the next rollup anyway? @frewsxcv

@lorepozo lorepozo reopened this Sep 25, 2017
@arielb1
Copy link
Contributor

arielb1 commented Sep 26, 2017

@lucasem

I think you're still in the bors queue.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 29, 2017
docs improvement std::sync::{PoisonError, TryLockError}

Addresses the `PoisonError` and `TryLockError` parts of rust-lang#29377.
Adds examples and links.

r? @steveklabnik
bors added a commit that referenced this pull request Sep 30, 2017
@bors
Copy link
Contributor

bors commented Sep 30, 2017

☔ The latest upstream changes (presumably #44936) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

Merged in #44936.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants