Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the behavior of UDP sockets wrt. multiple addresses in connect #44388

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Clarify the behavior of UDP sockets wrt. multiple addresses in connect #44388

merged 1 commit into from
Sep 15, 2017

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Sep 7, 2017

@rust-highfive
Copy link
Collaborator

r? @BurntSushi

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton alexcrichton added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2017
frewsxcv
frewsxcv reviewed Sep 10, 2017
View reviewed changes
src/libstd/net/udp.rs
/// Unlike in the TCP case, passing an array of addresses to the `connect`
/// function of a UDP socket is not a useful thing to do: The OS will be
/// unable to determine whether something is listening on the remote
/// address without the application sending data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is no longer associated with an example, seems like we can move this paragraph above the # Examples heading. what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My rationale for leaving it there was that this explanation is in a similar spot for the other methods and also in TcpStream. But I guess I can move it up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the text is already up there. It's just summarized in the examples because there's usually an example of using multiple addresses.

@frewsxcv
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 10, 2017

📌 Commit b4d0f61 has been approved by frewsxcv

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 11, 2017
@frewsxcv
Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…
dc34c64 
…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209
@frewsxcv frewsxcv mentioned this pull request Sep 11, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 11, 2017
@frewsxcv
Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…
322a731 
…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209
@frewsxcv frewsxcv mentioned this pull request Sep 11, 2017
Closed
@BurntSushi
Copy link
Member

This seems fine to me. It might be worth noting that these docs appear to be strengthening the contract of connect to say in more detail what's actually going on behind the curtain. But it still seems reasonable to me!

@BurntSushi BurntSushi added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 13, 2017
@GuillaumeGomez
Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…
95a0696 
…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 13, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 14, 2017
@frewsxcv
Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…
273922f 
…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209
@frewsxcv frewsxcv mentioned this pull request Sep 14, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 15, 2017
@frewsxcv
Rollup merge of rust-lang#44388 - tbu-:pr_doc_udp_connect_multiple, r…
eb45c0a 
…=frewsxcv

Clarify the behavior of UDP sockets wrt. multiple addresses in `connect`

CC @frewsxcv rust-lang#22569 rust-lang#44209
@frewsxcv frewsxcv mentioned this pull request Sep 15, 2017
Merged
bors added a commit that referenced this pull request Sep 15, 2017
@bors
Auto merge of #44585 - frewsxcv:rollup, r=frewsxcv
d86a7f7 
Rollup of 23 pull requests

- Successful merges: #44131, #44254, #44368, #44374, #44378, #44388, #44430, #44450, #44453, #44472, #44476, #44477, #44485, #44497, #44521, #44534, #44536, #44541, #44552, #44559, #44563, #44569, #44572
- Failed merges:
@bors bors merged commit b4d0f61 into rust-lang:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv left review comments

Assignees

@BurntSushi BurntSushi

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tbu- @rust-highfive @frewsxcv @bors @BurntSushi @alexcrichton