Implement named threads on Windows (v2) #44374
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Nice! |
|
📌 Commit 8e80cee has been approved by |
alexcrichton
added
the
S-waiting-on-bors
| // The names in MSVC debugger are obtained using a "magic" exception, | ||
| // which requires a use of MS C++ extensions. | ||
| // See https://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx | ||
| pub fn set_name(name: &CStr) { |
There was a problem hiding this comment.
It seems kinda silly that this function still takes CStr.
|
⌛ Testing commit 8e80cee with merge d146ac2bdd1ffa36b20b7563bb40f3f6a5354c92... |
|
prioritizing rollup @bors retry |
Implement named threads on Windows (v2) https://msdn.microsoft.com/en-us/library/windows/desktop/mt774976(v=vs.85).aspx Windows 10 version 1607 finally added a sensible API for naming threads, so we can now implement named threads without having to use MSVC compiler extensions like before. VS2017s debugger and the WPA profiler already use this API where available, but other tools may need some time to catch up. 
Implement named threads on Windows (v2) https://msdn.microsoft.com/en-us/library/windows/desktop/mt774976(v=vs.85).aspx Windows 10 version 1607 finally added a sensible API for naming threads, so we can now implement named threads without having to use MSVC compiler extensions like before. VS2017s debugger and the WPA profiler already use this API where available, but other tools may need some time to catch up. 
|
☔ The latest upstream changes (presumably #43972) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors: r+ |
|
📌 Commit 597ac36 has been approved by |
Implement named threads on Windows (v2) https://msdn.microsoft.com/en-us/library/windows/desktop/mt774976(v=vs.85).aspx Windows 10 version 1607 finally added a sensible API for naming threads, so we can now implement named threads without having to use MSVC compiler extensions like before. VS2017s debugger and the WPA profiler already use this API where available, but other tools may need some time to catch up. 
https://msdn.microsoft.com/en-us/library/windows/desktop/mt774976(v=vs.85).aspx
Windows 10 version 1607 finally added a sensible API for naming threads, so we can now implement named threads without having to use MSVC compiler extensions like before. VS2017s debugger and the WPA profiler already use this API where available, but other tools may need some time to catch up.