Inject std when --test. #1127, #3241 #4309
Closed
+40
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @pcwalton
This solves some long standing issues with
--test
, automatically linking tostd
. It may also help with the resolution changes you are working on.When building a test runner it does something like this
Then, whenever it builds paths to
std
it usesself::std::test
to reference the injectedstd
. When building a test runner forstd
it instead uses paths like::test
.As a side-effect, core no longer needs to declare a magic
std
module.This isn't fully tested yet because of some breakage with stdtest on incoming.