[RFC] num: bitwise reflection methods #13209
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit-manipulation PR, however I still have some doubts:
reflect()
too generic? That's how the operation is usually called, but may be too broad as API and conflict with reflection/introspection.Bitwise
trait lacksOne
,Zero
andNumCast
for this implementation to work. Maybe they should be added anyway?impl Bitwise for i8..i64
in multiple files? Most of it is through instrinsics in each module, but ideallyreflect()
could be directly implemented in uint/int_macros abusing$T
.Let Bitwise provide a reflect() method for reversed binary
representation. This is a binary primitive used in several algorithms,
eg. CRC checksums.