Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce deprecated collections crate #42720

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Reintroduce deprecated collections crate #42720

merged 1 commit into from
Jun 18, 2017

Conversation

murarth
Copy link
Contributor

@murarth murarth commented Jun 17, 2017

No description provided.

@murarth
Copy link
Contributor Author

murarth commented Jun 17, 2017

r? @alexcrichton

cc #42648

@murarth
Copy link
Contributor Author

murarth commented Jun 17, 2017

I added collections as a dependency to libstd without declaring extern crate collections; anywhere. It seemed to be the only way to get x.py to build libcollections.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Jun 17, 2017

📌 Commit 6f7c228 has been approved by alexcrichton

@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 17, 2017
@murarth
Copy link
Contributor Author

murarth commented Jun 17, 2017

Broken links strike again.

@Mark-Simulacrum
Copy link
Member

@bors r-

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 17, 2017
@murarth
Copy link
Contributor Author

murarth commented Jun 17, 2017

Ah, it was because I forgot to re-export collections macros from alloc. Good thing that was caught somewhere.

@Mark-Simulacrum
Copy link
Member

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jun 17, 2017

📌 Commit 6484258 has been approved by alexcrichton

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 18, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42720 - murarth:deprecated-collections, r=a…
c982529 
…lexcrichton

Reintroduce deprecated `collections` crate
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 18, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 18, 2017
@frewsxcv
Rollup merge of rust-lang#42720 - murarth:deprecated-collections, r=a…
ff320a1 
…lexcrichton

Reintroduce deprecated `collections` crate
@frewsxcv frewsxcv mentioned this pull request Jun 18, 2017
Closed
bors added a commit that referenced this pull request Jun 18, 2017
@bors
Auto merge of #42738 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
247a018 
Rollup of 7 pull requests

- Successful merges: #42695, #42714, #42720, #42723, #42730, #42731, #42734
- Failed merges: #42722
@bors bors merged commit 6484258 into rust-lang:master Jun 18, 2017
@murarth murarth deleted the deprecated-collections branch June 18, 2017 20:20
@Pratyush Pratyush mentioned this pull request Jun 20, 2017
Merged
@leoyvens leoyvens mentioned this pull request Oct 22, 2017
Merged
bors added a commit that referenced this pull request Oct 24, 2017
@bors
Auto merge of #45446 - leodasvacas:remove-libcollections, r=alexcrichton
c2799fc 
Remove deprecated `collections` crate.

The real `collections` was merged with `alloc`, this facade was introduced [in this PR](#42720) to give `#[no_std]` users time to adapt. This was done at least two cycles ago, now we can consider removing it for good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@murarth @alexcrichton @bors @Mark-Simulacrum