-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use T as the subpattern type of Box<T> #42730
Conversation
The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@VBChunguk If you rephrase your PR description to have "#42679" right after the word "fixes", then GitHub will close it when this PR is merged. |
@bors r+ |
📌 Commit abebe8a has been approved by |
@bors rollup |
Use T as the subpattern type of Box<T> The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type. Fixes rust-lang#42679, which describes ICE caused by the bug.
Use T as the subpattern type of Box<T> The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type. Fixes rust-lang#42679, which describes ICE caused by the bug.
The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type.
Fixes #42679, which describes ICE caused by the bug.