Rollup of 26 pull requests #40596
Closed
Rollup of 26 pull requests #40596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of last year with version 'Sierra', the Mac operating system is now called 'macOS'.
This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
Primarily opened to address the concerns brought up in rust-lang#40498. * run rustfmt on code blocks * use `DefaultHasher` instead of deprecated `SipHasher` * rename `hash` to `calculate_hash` to prevent confusion with the `hash` method
Whenever we parse a chain of binary operations, as long as the first
operation is `<` and the subsequent operations are either `>` or `<`,
present the following diagnostic help:
use `::<...>` instead of `<...>` if you meant to specify type arguments
This will lead to spurious recommendations on situations like
`2 < 3 < 4` but should be clear from context that the help doesn't apply
in that case.
some style fixes
…g, r=steveklabnik Remove doc about highlighting code in other languages rust-lang#40301 This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301 Thoughts: - may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point; - does `text` still work? r? @steveklabnik
Updating README.md to point to the correct doc location
fix format grammar This is just a trivial change to get the escaped squigglies into the grammar. r? @steveklabnik
…rewsxcv Using X headings rust-lang#39850 Fix for issue rust-lang#39850, the headings should now be 1, 2, and 3.
…eGomez Fix sidebar not extending to the bottom of the page Fixes rust-lang#40459
Corrected very minor documentation detail about Unicode and Japanese
Japanese half-width and full-width romaji characters do have upper and lowercase according Unicode (but other Japanese characters do not). For example,
` assert_eq!('\u{FF21}'.to_lowercase().collect::<String>(),"\u{FF41}");`
r? @steveklabnik
Point out correct turbofish usage on `Foo<Bar<Baz>>`
Whenever we parse a chain of binary operations, as long as the first
operation is `<` and the subsequent operations are either `>` or `<`,
present the following diagnostic help:
use `::<...>` instead of `<...>` if you meant to specify type arguments
This will lead to spurious recommendations on situations like
`2 < 3 < 4` but should be clear from context that the help doesn't apply
in that case.
Fixes rust-lang#40396.
…sfackler std: remove a workaround for privacy limitations `std::thread::Thread` implements a non-exported `NewThread` trait to allow for internal-only use of `Thread::new`. Nowadays we have `pub(crate)`, which accomplishes the same thing but much more idiomatically. Rustdoc handles this correctly (I checked and I didn't see `Thread::new` on the rustdoc entry for `Thread` with this change), and the stage1 `rustc` emits the correct error still (I'm assuming that the stage1 compiler uses my `libstd`?): ``` $ ./build/x86_64-apple-darwin/stage1/bin/rustc test.rs error: method `new` is private --> test.rs:4:18 | 4 | let thread = thread::Thread::new(None); | ^^^^^^^^^^^^^^^^^^^ error: aborting due to previous error ```
A few improvements to the `core::hash` top-level docs. Primarily opened to address the concerns brought up in rust-lang#40498. * run rustfmt on code blocks * use `DefaultHasher` instead of deprecated `SipHasher` * rename `hash` to `calculate_hash` to prevent confusion with the `hash` method
.gitmodules: use official URLs w/o redirect
…excrichton Remove incorrect feature from the 1.16 relnotes According to @golddranks https://internals.rust-lang.org/t/rust-1-16-0-prerelease-testing/4953/3 r? @brson
…xcrichton Link core::slice to std::slice
Make docs required again Completely untested. Fixes rust-lang/rustup#903 r? @alexcrichton cc @steveklabnik
…, r=steveklabnik Fix documentation for Vec::dedup_by. The previous docstring was copied from dedup_by_key.
Library stabilizations for 1.17 Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17. Will need a beta backport, which I will create after approval. r? @alexcrichton
…ichton Removes Default for Box<Path>. This was not supposed to be added. cc @alexcrichton
…, r=nikomatsakis rustbuild: Retry downloads of OpenSSL source We need this to compile Cargo and we download it at build time, but as like all other network requests it has a chance of failing. This commit moves the source of the tarball to a mirror (S3 seems semi-more-reliable most of the time) and also wraps the download in a retry loop. cc rust-lang#40474
Remove unused param from bootstrap::clean::rm_rf None
…nstable-book, r=frewsxcv add sort_unstable to unstable book cc rust-lang#40585
|
Some changes occurred in HTML/CSS. |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit 365ae32 has been approved by |
|
⌛ Testing commit 365ae32 with merge 3abd349... |
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srcforptr::write{,_unaligned}#40387, Add test for issue #29595 #40433, Add basic documentation/examples for six unstable features. #40452, Remove function invokation parens from documentation links. #40456, Update usages of 'OSX' (and other old names) to 'macOS'. #40457, Add doc examples forOsStr,OsString. #40458, some style fixes #40463, Remove doc about highlighting code in other languages #40301 #40466, Updating README.md to point to the correct doc location #40467, fix format grammar #40495, Using X headings #39850 #40496, Fix sidebar not extending to the bottom of the page #40497, Corrected very minor documentation detail about Unicode and Japanese #40499, Point out correct turbofish usage onFoo<Bar<Baz>>#40500, std: remove a workaround for privacy limitations #40503, A few improvements to thecore::hashtop-level docs. #40505, .gitmodules: use official URLs w/o redirect #40512, Remove incorrect feature from the 1.16 relnotes #40517, Link core::slice to std::slice #40520, Make docs required again #40526, Fix documentation for Vec::dedup_by. #40536, Library stabilizations for 1.17 #40538, Removes Default for Box<Path>. #40539, rustbuild: Retry downloads of OpenSSL source #40545, Remove unused param from bootstrap::clean::rm_rf #40562, add sort_unstable to unstable book #40586