Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc sidebar styling doesn't extend to bottom of page if content is taller than sidebar #40459

Closed
frewsxcv opened this issue Mar 12, 2017 · 10 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@frewsxcv
Copy link
Member

Introduced in #40265

fireshot capture 2 - std - rust - https___doc rust-lang org_nightly_std_

@frewsxcv frewsxcv added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 12, 2017
@frewsxcv
Copy link
Member Author

cc @wesleywiser

@frewsxcv
Copy link
Member Author

Might be able to fix this using flexbox?

@steveklabnik
Copy link
Member

steveklabnik commented Mar 13, 2017 via email

@wesleywiser
Copy link
Member

I can't seem to repro this. What browser are you using?

@frewsxcv
Copy link
Member Author

Firefox 51.0.1

@wesleywiser
Copy link
Member

Hmm... I'm not seeing it on FF 52 on macOS

@frewsxcv
Copy link
Member Author

Since I didn't specify earlier, the page in the screenshot above is: https://doc.rust-lang.org/nightly/std/

@frewsxcv
Copy link
Member Author

In case there was any concern about version differences, I just upgraded to version 52.0 and can still reproduce the screenshot.

@wesleywiser
Copy link
Member

I can see it on that page. I was testing my local build which doesn't seem to be experiencing the issue.

@wesleywiser
Copy link
Member

For some reason, my local copy has

.sidebar {
    width: 100%;
}

instead of

.sidebar {
    width: 100vh;
}

I'm not sure why it's different but that fixes the issue.

wesleywiser added a commit to wesleywiser/rust that referenced this issue Mar 14, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 14, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 15, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
…eGomez

Fix sidebar not extending to the bottom of the page

Fixes rust-lang#40459
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants