-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta backports #38872
Beta backports #38872
Conversation
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
Fixed. |
@nikomatsakis could you back out the backport of 4781eb3 (the second commit of #38708), we should only need the first commit I believe, specifically d0881ea |
@nikomatsakis your list also claims #38792 was backported but the commits aren't showing up here for me? |
Ok I updated the list in the PR description to also reflect whether the PRs have been merged or not. We have less testing on beta than we do on master, so I personally prefer to wait for a merge to master before backporting, but we can also just re-backport fixes if necessary. |
I unchecked #38792 in the list above due to this comment |
hmm, yeah, I somehow overlooked that one, but in the other case I had just forgotten to push
will do |
Wowee! This is amazing. Thanks @nikomatsakis |
promotion of MIR terminators used to try to promote the destination it is trying to promote, leading to stack overflow. Fixes rust-lang#37991.
Includes special case handling for trait methods. Fix rust-lang#38412.
This reverts commit 1d23be75b95b1dad318020fcf110836a7f17fc80.
In order to be forward compatible with `where<'a>` syntax for higher rank parameters, prevent potential conflicts with UFCS from parsing correctly for the near term.
The source tarball creation step would attempt to skip a number of files that we want to ignore ourselves, but once we've hit the vendor directory we don't want to skip anything so be sure to vendor everything inside that directory. Closes rust-lang#38690
This commit stabilizes the `proc_macro` and `proc_macro_lib` features in the compiler to stabilize the "Macros 1.1" feature of the language. Many more details can be found on the tracking issue, rust-lang#35900. Closes rust-lang#35900
These are some bare-bones documentation for custom derive, needed to stabilize "macros 1.1", rust-lang#35900 The book chapter is based off of a blog post by @cbreeden, https://cbreeden.github.io/Macros11/ Normally, we have a policy of not mentioning external crates in documentation. However, given that syn/quote are basically neccesary for properly using macros 1.1, I feel that not including them here would make the documentation very bad. So the rules should be bent in this instance.
Thanks @nikomatsakis! |
This PR aims to backport all the beta PRs.
Here is a list with their status:
unused_qualifications
-check global paths #38817 (did not backport cleanly; will revisit -- or maybe @jseyfried can take a look)proc_macro
feature #38783#[macro_export] macro_rules!
#38793cc @rust-lang/compiler @alexcrichton @brson #