-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal compiler error: ../src/librustc/middle/stability.rs:516: encountered unmarked API #38412
Comments
cc #38087 @jseyfried |
@durka
|
Now a regression to beta. |
triage: P-high |
(for anyone else who like me is looking to applying bisection here: note that the build system changed during the same time span that one might start with for the bisection, and so you need to invoke the correct build system depending on where you are in the history. Furthermore, the build products go into different places depending on which build system you use, so if you're like me and not paying attention, you'll end up repeatedly invoking a build that came from the more recent build system even as you keep working your way back through the history via update: if you're curious as to how I could possibly have been doing builds with different build systems and not noticed, the answer is that I have a wrapper script that attempts to infer which build system to use. |
I think I know what is the reason. |
a hypothesis: Did we start running the stability checking pass (which as I understand it is the thing emitting the "unmarked api" errors) before we check for privacy violations? update: heh, I clearly added this comment without refreshing the page, so I missed @petrochenkov coming to the same conclusion. |
This'll need a backport to 1.15, and we've got about 3 weeks to get it in. |
Includes special case handling for trait methods. Fix rust-lang#38412.
…, r=nikomatsakis Dont check stability for items that are not pub to universe. Dont check stability for items that are not pub to universe. In other words, skip it for private and even `pub(restricted)` items, because stability checks are only relevant to things visible in other crates. Fix #38412.
Includes special case handling for trait methods. Fix rust-lang#38412.
…to_privacy, r=compiler-errors stability: remove skip_stability_check_due_to_privacy This was added in rust-lang#38689 to deal with rust-lang#38412. However, even after removing the check, the relevant tests still pass. Let's see if CI finds any other tests that rely on this. If not, it seems like logic elsewhere in the compiler changed so this is not required any more.
…to_privacy, r=compiler-errors stability: remove skip_stability_check_due_to_privacy This was added in rust-lang#38689 to deal with rust-lang#38412. However, even after removing the check, the relevant tests still pass. Let's see if CI finds any other tests that rely on this. If not, it seems like logic elsewhere in the compiler changed so this is not required any more.
Rollup merge of rust-lang#133157 - RalfJung:skip_stability_check_due_to_privacy, r=compiler-errors stability: remove skip_stability_check_due_to_privacy This was added in rust-lang#38689 to deal with rust-lang#38412. However, even after removing the check, the relevant tests still pass. Let's see if CI finds any other tests that rely on this. If not, it seems like logic elsewhere in the compiler changed so this is not required any more.
The following code causes the compiler to crash on nightly (stable and beta unaffected):
https://is.gd/RE6AiB
The error message says:
Meta
rustc --version --verbose
:Backtrace:
The text was updated successfully, but these errors were encountered: