Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DefId's in const eval for cross-crate const fn's #37557

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Use DefId's in const eval for cross-crate const fn's #37557

merged 1 commit into from
Nov 6, 2016

Conversation

TimNN
Copy link
Contributor

@TimNN TimNN commented Nov 3, 2016

Fixes #36954.

r? @eddyb

cc @raphaelcohn

@eddyb
Copy link
Member

eddyb commented Nov 3, 2016

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Nov 3, 2016

📌 Commit dc138b3 has been approved by eddyb

@bors
Copy link
Contributor

bors commented Nov 3, 2016

⌛ Testing commit dc138b3 with merge 250665e...

@bors
Copy link
Contributor

bors commented Nov 3, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 4, 2016
Rollup merge of rust-lang#37557 - TimNN:fix-36954, r=eddyb
fbcb057 
Use DefId's in const eval for cross-crate const fn's

Fixes rust-lang#36954.

r? @eddyb

cc @raphaelcohn
@sophiajt sophiajt mentioned this pull request Nov 4, 2016
Closed
@eddyb eddyb mentioned this pull request Nov 4, 2016
Closed
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 4, 2016
@alexcrichton
Rollup merge of rust-lang#37557 - TimNN:fix-36954, r=eddyb
af47505 
Use DefId's in const eval for cross-crate const fn's

Fixes rust-lang#36954.

r? @eddyb

cc @raphaelcohn
@alexcrichton alexcrichton mentioned this pull request Nov 4, 2016
Merged
@bors
Copy link
Contributor

bors commented Nov 5, 2016

⌛ Testing commit dc138b3 with merge 53b1df0...

@bors
Copy link
Contributor

bors commented Nov 5, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Nov 4, 2016 at 10:37 PM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2929

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#37557 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95M5NbUCHVyWcmO9cepv-tM3qf9w7ks5q7BYugaJpZM4KoPZf
.

bors added a commit that referenced this pull request Nov 5, 2016
@bors
Auto merge of #37597 - alexcrichton:rollup, r=alexcrichton
16d5330 
Rollup of 24 pull requests

- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Nov 5, 2016
Rollup merge of rust-lang#37557 - TimNN:fix-36954, r=eddyb
9296ed9 
Use DefId's in const eval for cross-crate const fn's

Fixes rust-lang#36954.

r? @eddyb

cc @raphaelcohn
@sophiajt sophiajt mentioned this pull request Nov 5, 2016
Closed
@bors
Copy link
Contributor

bors commented Nov 5, 2016

⌛ Testing commit dc138b3 with merge ac65142...

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 5, 2016
@alexcrichton
Rollup merge of rust-lang#37557 - TimNN:fix-36954, r=eddyb
b4aee37 
Use DefId's in const eval for cross-crate const fn's

Fixes rust-lang#36954.

r? @eddyb

cc @raphaelcohn
@bors
Copy link
Contributor

bors commented Nov 5, 2016

⛄ The build was interrupted to prioritize another pull request.

bors added a commit that referenced this pull request Nov 6, 2016
@bors
Auto merge of #37597 - alexcrichton:rollup, r=alexcrichton
3fc8304 
Rollup of 24 pull requests

- Successful merges: #37255, #37317, #37408, #37410, #37422, #37427, #37470, #37501, #37537, #37556, #37557, #37564, #37565, #37566, #37569, #37574, #37577, #37579, #37583, #37585, #37586, #37587, #37589, #37596
- Failed merges: #37521, #37547
@bors bors merged commit dc138b3 into rust-lang:master Nov 6, 2016
@TimNN TimNN deleted the fix-36954 branch January 9, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TimNN @eddyb @bors @alexcrichton