Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call arrays "arrays" instead of "vecs" internally #36599

Merged
merged 5 commits into from
Oct 1, 2016
Merged

Call arrays "arrays" instead of "vecs" internally #36599

merged 5 commits into from
Oct 1, 2016

Conversation

jonas-schievink
Copy link
Contributor

Contains a syntax-[breaking-change] as a separate commit (cc #31645).

Also renames slice patterns from PatKind::Vec to PatKind::Slice.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BoxMutability,
PtrMutability,
RefMutability,
VecMutability,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@bors
Copy link
Contributor

bors commented Sep 22, 2016

☔ The latest upstream changes (presumably #36551) made this pull request unmergeable. Please resolve the merge conflicts.

@pnkfelix
Copy link
Member

r=me. @Manishearth I'm guessing this should be part of a syntax breaking-batch?

@Manishearth
Copy link
Member

Yep. Let me know if you need a batch, this seems like something that can bitrot soon.

@bors
Copy link
Contributor

bors commented Sep 27, 2016

☔ The latest upstream changes (presumably #36764) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Sep 28, 2016

☔ The latest upstream changes (presumably #36601) made this pull request unmergeable. Please resolve the merge conflicts.

These weren't flagged by the lint because they were still technically
created somewhere... if you created them before, somehow.
This applies the HIR changes from the previous commits to the AST, and
is thus a syntax-[breaking-change]

Renames `PatKind::Vec` to `PatKind::Slice`, since these are called slice
patterns, not vec patterns. Renames `TyKind::Vec`, which represents the
type `[T]`, to `TyKind::Slice`. Renames `TyKind::FixedLengthVec` to
`TyKind::Array`.
@jonas-schievink
Copy link
Contributor Author

@Manishearth Okay, let's do a batch, this bitrots really quickly

@Manishearth
Copy link
Member

Yep. I plan to do one soon, but I'm at a conference and will be traveling tomorrow so I can't do it until Saturdayish

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 30, 2016
…orite-data-structure, r=

 Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 1, 2016
…orite-data-structure, r=pnkfelix

 Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.
@bors bors merged commit bc2b283 into rust-lang:master Oct 1, 2016
@jonas-schievink jonas-schievink deleted the whats-a-pirates-favorite-data-structure branch October 1, 2016 22:22
dtolnay added a commit to dtolnay/syn that referenced this pull request Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants