Tracking issue for libsyntax breaking changes #31645

Manishearth · 2016-02-14T02:01:39Z

See also: https://internals.rust-lang.org/t/please-consider-stability-of-libsyntax/2947

We decided to batch up breaking changes to oft-used unstable compiler internals (mainly, libsyntax) until they're large enough; so that the impact of these breaking changes is minimized. (For example, every time libsyntax breaks, aster and transitively everyone using serde on nightly has to fix it)

Let's try to coordinate these in the future through this issue. We can list breaking PRs here and batch them up when we feel that they're large enough (or when there's another inevitable breaking change about to merge). Merge them when there's enough time for the folks below to know about it, and preferably make PRs to the larger projects below beforehand.

CCing stakeholders:

libsyntax: @nrc @huonw @eddyb
clippy: me, @llogiq
diesel: @sgrif
phf: @sfackler
regex_macros: @BurntSushi, @alexcrichton
rust-cpp, other plugins: @mystor

Add more if you know of them!

BurntSushi · 2016-02-15T15:04:45Z

I would also like to re-submit my plea that commits with breaking changes are tagged, and if possible, at least some message that hints at or explains how to fix breakages.

Other crates with macros in use (apparently) are docopt_macros and quickcheck_macros.

Manishearth · 2016-02-15T16:14:21Z

Yeah, they get tagged with [breaking-change]. With this bug in place they should also be posted here first and we can notify everyone well in advance before a rollup.

@pnkfelix

[breaking-batch] Add support for `pub(restricted)` syntax in the AST This PR allows the AST to represent the `pub(restricted)` syntax from RFC 1422 (cc #32409). More specifically, it makes `ast::Visibility` non-`Copy` and adds two new variants, `Visibility::Crate` for `pub(crate)` and `Visitibility::Restricted { path: P<Path>, id: NodeId }` for `pub(path)`. plugin-[breaking-change] cc #31645 r? @pnkfelix

Manishearth · 2016-04-06T11:12:14Z

#32767 is a breaking change that will land soon, along with #32688.

I'd normally wait a few days before merging these so that everyone can fix their code early, but in this case #32688 already landed so there's not much I can do.

This will definitely break syntex and friends, cc @erickt. I've never looked at diesel's code so it may or may not break it, @sgrif you may want to have a look before this lands in the nightly.

sgrif · 2016-04-06T11:27:32Z

Thanks for the ping, definitely going to cause breakage.

@Manishearth

The AST part of rust-lang#31937 Unlike HIR, AST still uses `Option` for field names because parser can't know field indexes reliably due to constructions like ``` struct S(#[cfg(false)] u8, u8); // The index of the second field changes from 1 during parsing to 0 after expansion. ``` and I wouldn't like to put the burden of renaming fields on expansion passes and syntax extensions. plugin-[breaking-change] cc rust-lang#31645 r? @Manishearth

Batch up all plugin breaking changes #32688 already landed so we should get this into the same nightly. cc #31645

Manishearth · 2016-04-18T22:18:05Z

#33041 will land in a few days. It changes the parser and some of the token tree representation

Definitely will break syntex/aster/serde (cc @erickt)
Might break Diesel, Regex, phf (cc @sgrif, @sfackler, @BurntSushi): anyone who uses macros operating on token trees.

Manishearth · 2016-04-20T05:19:56Z

Note that #31414 has been added to the rollup. It will break derive plugins, not sure what else.

Manishearth · 2016-04-21T05:58:58Z

Also #33125

So far, we will be landing

once they all get approved

Manishearth · 2016-04-22T21:13:47Z

#33157 is also in the list

…arth Track the span corresponding to the `|...|` part of the closure. lifted from rust-lang#32756 cc rust-lang#31645 libsyntax-[breaking change]

Manishearth · 2016-04-24T12:47:09Z

Merging now: #33179

Batch up breaking libsyntax changes Contains: - #33125 - #33041 - #33157 cc #31645

Manishearth · 2016-08-21T09:13:02Z

Next breaking batch will contain the above PRs, waiting on the last one. cc @dtolnay @sfackler @mystor @sgrif @BurntSushi

Manishearth · 2016-08-26T03:46:00Z

Everything seems reviewed, breaking batch will be made todayish (and land over the weekend).

cc @dtolnay @BurntSushi @sgrif @sfackler @llogiq

Manishearth · 2016-08-30T12:05:26Z

Batch at #36066

Manishearth · 2016-08-30T13:13:38Z

Landed!

Manishearth · 2016-09-06T03:19:43Z

Stuff for next batch:

Fix the return type of AstBuilder.stmt_let_typed #35874 (r=Manishearth)
Call arrays "arrays" instead of "vecs" internally #36599 (r=pnkfelix)
Attributes on generic formals #34764 (r=eddyb)

- ~~Refactor away RBML from rustc_metadata. #36551~~

mergerollup CensoredUsername:stmt_let_typed_fix 35874 Manishearth
mergerollup jonas-schievink:whats-a-pirates-favorite-data-structure 36599 pnkfelix
mergerollup pnkfelix:attrs-on-generic-formals 34764 eddyb

mcarton · 2016-09-23T13:53:55Z

@Manishearth don't know if it's to late for the two other PRs to make it into the next nightly, but #36551 was a syntax breaking change and has already been merged.

Manishearth · 2016-09-23T14:31:35Z

Too late :/ But we're rolling it up now anyway

…orite-data-structure, r= Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.

Manishearth · 2016-09-30T12:17:23Z

Breaking batch at #36857 cc @dtolnay @sgrif @BurntSushi

Will merge tomorrowish.

dtolnay · 2016-09-30T14:29:02Z

This is exciting - I am not planning to do a serde_macros release so we will see if people revolt or move to serde_derive.

Manishearth · 2016-09-30T14:31:01Z

Should we PSA this?

dtolnay · 2016-09-30T14:37:41Z

The announcement that we are dropping serde_macros was at the top of reddit for a while and also popular on u.r-l.o. I think people will put two and two together when their builds fail. Worst case we get a handful of issues filed and we point them to the announcement. Do you know a better way to reach people who have not seen either of those already?

sfackler · 2016-09-30T14:39:07Z

You could potentially cut a new release that panics with a message telling people to move to serde-derive.

mcarton · 2016-09-30T14:43:44Z

@dtolnay Has this been announced in the Project Updates section of TWiR?

dtolnay · 2016-09-30T14:45:51Z

No we just missed the last one.

Manishearth · 2016-09-30T14:46:11Z

The panicky method feels a bit invasive imo.

It should be worth mentioning somewhere (perhaps on the crates.io page, or in the readme) that the method for upgrading is to switch over to the new macro version.

eddyb · 2016-09-30T14:49:17Z

If it has access to the diagnostics machinery, printing a deprecation warning wouldn't be that hard.

…orite-data-structure, r=pnkfelix Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.

Manishearth · 2016-10-01T17:22:22Z

This landed. beware the breakage!

sgrif · 2016-10-03T21:06:52Z

We should be done with the macros 1.1 port later today so I no longer need to get pinged on these. Thank you for including me though!

petrochenkov · 2019-06-22T00:14:31Z

Proc macros are not tied to libsyntax now, so this is no longer relevant.

Manishearth added metabug Issues about issues themselves ("bugs about bugs") A-syntaxext Area: Syntax extensions labels Feb 14, 2016

jonas-schievink mentioned this issue Mar 9, 2016

[breaking-batch] Move more uses of panictry! out of libsyntax #31631

Merged

This was referenced Apr 2, 2016

groundwork for RFC 1422, improve PrivateItemsInPublicInterfacesVisitor #32674

Merged

[breaking-batch] Simplify ast::StructField #32682

Merged

jseyfried mentioned this issue Apr 2, 2016

[breaking-batch] Add support for pub(restricted) syntax in the AST #32688

Merged

Manishearth mentioned this issue Apr 3, 2016

Macro expansion bypasses #[derive_*] stability checks. #32655

Closed

Manishearth mentioned this issue Apr 6, 2016

Batch up all plugin breaking changes #32767

Merged

bors added a commit that referenced this issue Apr 6, 2016

Auto merge of #32767 - Manishearth:breakingbatch, r=eddyb

943ec3b

Batch up all plugin breaking changes #32688 already landed so we should get this into the same nightly. cc #31645

This was referenced Apr 18, 2016

syntax: Make parsing of paths whitespace agnostic + some other changes #33041

Merged

special-case #[derive(Copy, Clone)] with a shallow clone #31414

Merged

Manishearth mentioned this issue Apr 21, 2016

Thread tighter span for closures around #33125

Merged

Manishearth mentioned this issue Apr 24, 2016

Batch up breaking libsyntax changes #33179

Merged

bors added a commit that referenced this issue Apr 24, 2016

Auto merge of #33179 - Manishearth:breaking-batch, r=Manishearth

1930483

Batch up breaking libsyntax changes Contains: - #33125 - #33041 - #33157 cc #31645

Manishearth mentioned this issue Aug 21, 2016

Implement RFC#1559: allow all literals in attributes #35850

Merged

This was referenced Aug 22, 2016

Move E0379 check from typeck to ast validation #35480

Merged

syntax: Remove traits AttrMetaMethods, AttributeMethods, and AttrNestedMetaItemMethods #35917

Merged

sanxiyn mentioned this issue Sep 19, 2016

Clarify the workings of StringReader in the lexer #36470

Closed

jonas-schievink mentioned this issue Sep 20, 2016

Call arrays "arrays" instead of "vecs" internally #36599

Merged

nnethercote mentioned this issue Oct 4, 2016

Clarify the positions of the lexer and parser #36969

Merged

Mark-Simulacrum added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. and removed metabug Issues about issues themselves ("bugs about bugs") labels Jul 24, 2017

petrochenkov closed this as completed Jun 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for libsyntax breaking changes #31645

Tracking issue for libsyntax breaking changes #31645

Manishearth commented Feb 14, 2016 •

edited by dtolnay

Loading

BurntSushi commented Feb 15, 2016

Manishearth commented Feb 15, 2016

Manishearth commented Apr 6, 2016

sgrif commented Apr 6, 2016

Manishearth commented Apr 18, 2016

Manishearth commented Apr 20, 2016

Manishearth commented Apr 21, 2016 •

edited

Loading

Manishearth commented Apr 22, 2016

Manishearth commented Apr 24, 2016

Manishearth commented Aug 21, 2016

Manishearth commented Aug 26, 2016

Manishearth commented Aug 30, 2016

Manishearth commented Aug 30, 2016

Manishearth commented Sep 6, 2016 •

edited

Loading

mcarton commented Sep 23, 2016

Manishearth commented Sep 23, 2016

Manishearth commented Sep 30, 2016 •

edited

Loading

dtolnay commented Sep 30, 2016

Manishearth commented Sep 30, 2016

dtolnay commented Sep 30, 2016

sfackler commented Sep 30, 2016

mcarton commented Sep 30, 2016

dtolnay commented Sep 30, 2016

Manishearth commented Sep 30, 2016

eddyb commented Sep 30, 2016

Manishearth commented Oct 1, 2016

sgrif commented Oct 3, 2016

petrochenkov commented Jun 22, 2019

Tracking issue for libsyntax breaking changes #31645

Tracking issue for libsyntax breaking changes #31645

Comments

Manishearth commented Feb 14, 2016 • edited by dtolnay Loading

BurntSushi commented Feb 15, 2016

Manishearth commented Feb 15, 2016

Manishearth commented Apr 6, 2016

sgrif commented Apr 6, 2016

Manishearth commented Apr 18, 2016

Manishearth commented Apr 20, 2016

Manishearth commented Apr 21, 2016 • edited Loading

Manishearth commented Apr 22, 2016

Manishearth commented Apr 24, 2016

Manishearth commented Aug 21, 2016

Manishearth commented Aug 26, 2016

Manishearth commented Aug 30, 2016

Manishearth commented Aug 30, 2016

Manishearth commented Sep 6, 2016 • edited Loading

mcarton commented Sep 23, 2016

Manishearth commented Sep 23, 2016

Manishearth commented Sep 30, 2016 • edited Loading

dtolnay commented Sep 30, 2016

Manishearth commented Sep 30, 2016

dtolnay commented Sep 30, 2016

sfackler commented Sep 30, 2016

mcarton commented Sep 30, 2016

dtolnay commented Sep 30, 2016

Manishearth commented Sep 30, 2016

eddyb commented Sep 30, 2016

Manishearth commented Oct 1, 2016

sgrif commented Oct 3, 2016

petrochenkov commented Jun 22, 2019

Manishearth commented Feb 14, 2016 •

edited by dtolnay

Loading

Manishearth commented Apr 21, 2016 •

edited

Loading

Manishearth commented Sep 6, 2016 •

edited

Loading

Manishearth commented Sep 30, 2016 •

edited

Loading