Batch up libsyntax breaking changes #36066

jseyfried · 2016-08-28T11:22:55Z

Batch of the following syntax-[breaking-change] changes:

Add Span field for Generics structs #35591: Add a field span: Span to ast::Generics.
Refactor PathListItems #35618: Remove variant Mod of ast::PathListItemKind and refactor the remaining variant ast::PathListKind::Ident to a struct ast::PathListKind_.
Move E0379 check from typeck to ast validation #35480: Change uses of Constness in the AST to Spanned<Constness>.
- c.f. MethodSig, ItemKind
Fix #[derive] for empty tuple structs/variants #35728: Refactor cx.pat_enum() into cx.pat_tuple_struct() and cx.pat_path().
Implement RFC#1559: allow all literals in attributes #35850: Generalize the elements of lists in attributes from MetaItem to a new type NestedMetaItem that can represent a MetaItem or a literal.
syntax: Remove traits AttrMetaMethods, AttributeMethods, and AttrNestedMetaItemMethods #35917: Remove traits AttrMetaMethods, AttributeMethods, and AttrNestedMetaItemMethods.
- Besides removing imports of these traits, this won't cause fallout.
Add a variant Union to ItemKind to future proof for union (c.f. Implement untagged unions (RFC 1444) #36016).
Remove inherent methods attrs and fold_attrs of Annotatable.
- Use methods attrs and map_attrs of HasAttrs instead.

and refactor `ast::PathListItemKind::Ident` -> `ast::PathListItem_`.

and refacotor `hir::PathListItem_::Ident` -> `hir::PathListItem_`.

Add Span field for Generics structs

…=eddyb Refactor `PathListItem`s This refactors away variant `Mod` of `ast::PathListItemKind` and refactors the remaining variant `Ident` to a struct `ast::PathListItem_`.

Move E0379 check from typeck to ast validation Part of rust-lang#35233. Extension of rust-lang#35338, rust-lang#35364. Fixes rust-lang#35404.

Fix #[derive] for empty tuple structs/variants This was missing from rust-lang#35138

Implement RFC#1559: allow all literals in attributes Implemented rust-lang/rfcs#1559, tracked by rust-lang#34981.

…=nrc syntax: Remove traits `AttrMetaMethods`, `AttributeMethods`, and `AttrNestedMetaItemMethods`

Manishearth · 2016-08-28T11:51:59Z

@bors r+ p=10

bors · 2016-08-28T11:52:00Z

📌 Commit 9ab0633 has been approved by Manishearth

bors · 2016-08-28T13:20:47Z

⌛ Testing commit 9ab0633 with merge 27ab959...

bors · 2016-08-28T14:28:19Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

petrochenkov · 2016-08-28T15:05:45Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

run-pass\union\union-xcrate.rs fails.
Can you just remove this test? Something is legitimately wrong there, but I don't want to block the batch, I'll investigate today or tomorrow.

jseyfried · 2016-08-29T02:01:02Z

@bors r=Manishearth p=10

bors · 2016-08-29T02:01:04Z

📌 Commit 3d881a8 has been approved by Manishearth

bors · 2016-08-29T05:54:43Z

📌 Commit cdde06e has been approved by Manishearth

bors · 2016-08-29T05:54:55Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: rustbuild: smarter git submodule-ing #36062

bors · 2016-08-29T05:54:56Z

📌 Commit cdde06e has been approved by Manishearth

bors · 2016-08-29T07:49:01Z

⌛ Testing commit cdde06e with merge 13349fe...

bors · 2016-08-29T08:01:36Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

petrochenkov · 2016-08-29T10:01:39Z

@jseyfried

I removed #36016 and instead added a commit that future proofs the AST so that #36016 is no longer a syntax-[breaking-change].

There are also derive changes - supports_unions: bool needs to be added to deriving::generic::TraitDef for future proofing, see d7ed590 and 49eb1d2.

jseyfried · 2016-08-29T11:16:47Z

@petrochenkov Good point, I added supports_unions: bool in the above commit.

jseyfried · 2016-08-30T03:06:55Z

@bors r=Manishearth p=10

bors · 2016-08-30T03:06:56Z

📌 Commit 04f54b2 has been approved by Manishearth

bors · 2016-08-30T04:27:17Z

⌛ Testing commit 04f54b2 with merge 5998b37...

bors · 2016-08-30T05:44:15Z

💔 Test failed - auto-win-gnu-32-opt-rustbuild

jseyfried · 2016-08-30T05:55:03Z

@bors r=Manishearth p=10

bors · 2016-08-30T05:55:04Z

📌 Commit 02f081c has been approved by Manishearth

bors · 2016-08-30T07:36:19Z

⌛ Testing commit 02f081c with merge 71ee82a...

@Manishearth

Batch up libsyntax breaking changes Batch of the following syntax-[breaking-change] changes: - #35591: Add a field `span: Span` to `ast::Generics`. - #35618: Remove variant `Mod` of `ast::PathListItemKind` and refactor the remaining variant `ast::PathListKind::Ident` to a struct `ast::PathListKind_`. - #35480: Change uses of `Constness` in the AST to `Spanned<Constness>`. - c.f. `MethodSig`, `ItemKind` - #35728: Refactor `cx.pat_enum()` into `cx.pat_tuple_struct()` and `cx.pat_path()`. - #35850: Generalize the elements of lists in attributes from `MetaItem` to a new type `NestedMetaItem` that can represent a `MetaItem` or a literal. - #35917: Remove traits `AttrMetaMethods`, `AttributeMethods`, and `AttrNestedMetaItemMethods`. - Besides removing imports of these traits, this won't cause fallout. - Add a variant `Union` to `ItemKind` to future proof for `union` (c.f. #36016). - Remove inherent methods `attrs` and `fold_attrs` of `Annotatable`. - Use methods `attrs` and `map_attrs` of `HasAttrs` instead. r? @Manishearth

bors · 2016-08-30T13:01:37Z

petrochenkov and others added 20 commits August 18, 2016 01:07

Fix #[derive] for empty tuple structs/variants

28ed8b1

Split AstBuilder::pat_enum into pat_tuple_struct and pat_path

f6e06a8

Add Span field for Generics structs

5948182

Refactor away variant ast::PathListItemKind::Mod

98ce875

and refactor `ast::PathListItemKind::Ident` -> `ast::PathListItem_`.

Refactor away variant hir::PathListItem_::Mod

c4d577b

and refacotor `hir::PathListItem_::Ident` -> `hir::PathListItem_`.

Fix fallout in rustdoc.

9d99fe9

Implement RFC#1559: allow all literals in attributes.

8250a26

Refactor away AttrNestedMetaItemMethods.

4eb08bb

Refactor away AttributeMethods.

e264828

Refactor away AttrMetaMethods.

bfb01bb

Fix fallout in tests.

469753f

Move E0379 check from typeck to ast validation

1e9e798

Change Constness to Spanned<Constness>

aa5c4bb

Add UI test for E0379

e46b09a

Rollup merge of rust-lang#35591 - GuillaumeGomez:generics_span, r=jntrmr

b833e8d

Add Span field for Generics structs

Rollup merge of rust-lang#35618 - jseyfried:ast_view_path_refactor, r…

37f3017

…=eddyb Refactor `PathListItem`s This refactors away variant `Mod` of `ast::PathListItemKind` and refactors the remaining variant `Ident` to a struct `ast::PathListItem_`.

Rollup merge of rust-lang#35480 - KiChjang:e0379-bonus, r=nikomatsakis

bd38e89

Move E0379 check from typeck to ast validation Part of rust-lang#35233. Extension of rust-lang#35338, rust-lang#35364. Fixes rust-lang#35404.

Rollup merge of rust-lang#35728 - petrochenkov:empderive, r=manishearth

413ecde

Fix #[derive] for empty tuple structs/variants This was missing from rust-lang#35138

Rollup merge of rust-lang#35850 - SergioBenitez:master, r=nrc

6303640

Implement RFC#1559: allow all literals in attributes Implemented rust-lang/rfcs#1559, tracked by rust-lang#34981.

Rollup merge of rust-lang#35917 - jseyfried:remove_attr_ext_traits, r…

c14ff28

…=nrc syntax: Remove traits `AttrMetaMethods`, `AttributeMethods`, and `AttrNestedMetaItemMethods`

rust-highfive assigned Manishearth Aug 28, 2016

mcarton mentioned this pull request Aug 28, 2016

Rustup to *rustc 1.13.0-nightly (eac41469d 2016-08-30)* and bump to 0.0.87 rust-lang/rust-clippy#1204

Merged

petrochenkov mentioned this pull request Aug 29, 2016

Implement untagged unions (RFC 1444) #36016

Merged

Future proof libsyntax_ext for union.

02f081c

jseyfried force-pushed the rollup branch from 04f54b2 to 02f081c Compare August 30, 2016 05:54

Manishearth mentioned this pull request Aug 30, 2016

Tracking issue for libsyntax breaking changes #31645

Closed

bors merged commit 02f081c into rust-lang:master Aug 30, 2016

jseyfried deleted the rollup branch October 16, 2016 09:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch up libsyntax breaking changes #36066

Batch up libsyntax breaking changes #36066

jseyfried commented Aug 28, 2016 •

edited

Loading

Manishearth commented Aug 28, 2016

bors commented Aug 28, 2016

bors commented Aug 28, 2016

bors commented Aug 28, 2016

petrochenkov commented Aug 28, 2016 •

edited

Loading

jseyfried commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

petrochenkov commented Aug 29, 2016

jseyfried commented Aug 29, 2016

jseyfried commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

jseyfried commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

Batch up libsyntax breaking changes #36066

Batch up libsyntax breaking changes #36066

Conversation

jseyfried commented Aug 28, 2016 • edited Loading

Manishearth commented Aug 28, 2016

bors commented Aug 28, 2016

bors commented Aug 28, 2016

bors commented Aug 28, 2016

petrochenkov commented Aug 28, 2016 • edited Loading

jseyfried commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

bors commented Aug 29, 2016

petrochenkov commented Aug 29, 2016

jseyfried commented Aug 29, 2016

jseyfried commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

jseyfried commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

bors commented Aug 30, 2016

jseyfried commented Aug 28, 2016 •

edited

Loading

petrochenkov commented Aug 28, 2016 •

edited

Loading