-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #35826
Rollup of 13 pull requests #35826
Commits on Aug 17, 2016
-
accumulate vector and assert for RangeFrom and RangeInclusive examples
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
Configuration menu - View commit details
-
Copy full SHA for 95c53b1 - Browse repository at this point
Copy the full SHA 95c53b1View commit details
Commits on Aug 18, 2016
-
replace Add example with something more evocative of addition
Currently most of the operator traits use trivial implementation examples that only perform side effects. Honestly, that might not be too bad for the sake of documentation; but anyway, here's a proposal to move a slightly modified version of the module-level point-addition example into the `Add` documentation, since it's more evocative of addition semantics. Part of rust-lang#29365 wrap identifiers in backticks minor rephrasing fix module-level documentation to be more truthful This branch changes the example for `Add` to no longer be a "minimum implementation that prints something to the screen".
Configuration menu - View commit details
-
Copy full SHA for dcee93a - Browse repository at this point
Copy the full SHA dcee93aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dc13ee - Browse repository at this point
Copy the full SHA 0dc13eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dae1406 - Browse repository at this point
Copy the full SHA dae1406View commit details -
Fix tiny spelling mistake in book
Changed datastructure to data structure
Configuration menu - View commit details
-
Copy full SHA for 6976991 - Browse repository at this point
Copy the full SHA 6976991View commit details -
Add a few doc examples for
std::ffi::OsStr
.* `std::ffi::OsStr::new`. * `std::ffi::OsStr::is_empty`. * `std::ffi::OsStr::len`.
Configuration menu - View commit details
-
Copy full SHA for c2b6f72 - Browse repository at this point
Copy the full SHA c2b6f72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06302cb - Browse repository at this point
Copy the full SHA 06302cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96bd6cf - Browse repository at this point
Copy the full SHA 96bd6cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 161cb36 - Browse repository at this point
Copy the full SHA 161cb36View commit details -
note that calling drop() explicitly is a compiler error
Part of rust-lang#29365 explain that std::mem::drop in prelude will invoke Drop change "prelude" -> "the prelude"; change links to reference-style move link references to links' section
Configuration menu - View commit details
-
Copy full SHA for a516dbb - Browse repository at this point
Copy the full SHA a516dbbView commit details -
replace
AddAssign
example with something more evocative of additionThis is analogous to PR rust-lang#35709 for the `Add` trait.
Configuration menu - View commit details
-
Copy full SHA for 6c66eaa - Browse repository at this point
Copy the full SHA 6c66eaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39f318b - Browse repository at this point
Copy the full SHA 39f318bView commit details
Commits on Aug 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2128d31 - Browse repository at this point
Copy the full SHA 2128d31View commit details -
Rollup merge of rust-lang#35709 - matthew-piziak:add-trait-example, r…
…=GuillaumeGomez replace `Add` example with something more evocative of addition Currently most of the operator traits use trivial implementation examples that only perform side effects. Honestly, that might not be too bad for the sake of documentation; but anyway, here's a proposal to move a slightly modified version of the module-level point-addition example into the `Add` documentation, since it's more evocative of addition semantics. Part of rust-lang#29365
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 39501e9 - Browse repository at this point
Copy the full SHA 39501e9View commit details -
Rollup merge of rust-lang#35710 - matthew-piziak:explicit-drop, r=ste…
…veklabnik note that calling drop() explicitly is a compiler error Part of rust-lang#29365
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for bb03ef1 - Browse repository at this point
Copy the full SHA bb03ef1View commit details -
Rollup merge of rust-lang#35758 - matthew-piziak:vec-assert-over-prin…
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 2f9ae0d - Browse repository at this point
Copy the full SHA 2f9ae0dView commit details -
Rollup merge of rust-lang#35775 - frewsxcv:os-str-doc-examples, r=Gui…
…llaumeGomez Add a few doc examples for `std::ffi::OsStr`.
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 8075826 - Browse repository at this point
Copy the full SHA 8075826View commit details -
Rollup merge of rust-lang#35778 - clementmiao:E0395_new_error_format,…
… r=jonathandturner updated E0395 to new error format Updated E0395 to new error format. Part of rust-lang#35233 Fixes rust-lang#35693 Thanks again for letting me help! r? @jonathandturner
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for e38299d - Browse repository at this point
Copy the full SHA e38299dView commit details -
Rollup merge of rust-lang#35780 - clementmiao:E0396_new_err_format, r…
…=jonathandturner updated E0396 to new error format Updated E0396 to new error format. Part of rust-lang#35233 Fixes rust-lang#35779 Thanks again for letting me help! r? @jonathandturner
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 8c74eb6 - Browse repository at this point
Copy the full SHA 8c74eb6View commit details -
Rollup merge of rust-lang#35781 - ErikUggeldahl:spellingfix, r=apasel422
Very minor spelling fix in the book Changed datastructure to data structure. r? @steveklabnik
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 46f1733 - Browse repository at this point
Copy the full SHA 46f1733View commit details -
Rollup merge of rust-lang#35793 - matthew-piziak:add-rhs-example, r=s…
…teveklabnik demonstrate `RHS != Self` use cases for `Add` and `Sub`
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for f60bf45 - Browse repository at this point
Copy the full SHA f60bf45View commit details -
Rollup merge of rust-lang#35794 - cantino:fix-typo, r=apasel422
Fix minor typo Minor typo in the book.
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for eb0250a - Browse repository at this point
Copy the full SHA eb0250aView commit details -
Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner
Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 20b4b99 - Browse repository at this point
Copy the full SHA 20b4b99View commit details -
Rollup merge of rust-lang#35806 - matthew-piziak:addassign-example, r…
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 16ce5dc - Browse repository at this point
Copy the full SHA 16ce5dcView commit details -
Rollup merge of rust-lang#35812 - mlayne:E0232, r=jonathandturner
Update error format for E0232 Fixes rust-lang#35795, as part of rust-lang#35233. Excited to make my first contribution to rustc! r? @jonathandturner
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for 5d18992 - Browse repository at this point
Copy the full SHA 5d18992View commit details -
Rollup merge of rust-lang#35818 - wdv4758h:E0133-label, r=Aatch
Fix label messages for E0133 Issue rust-lang#35789
Jonathan Turner authoredAug 19, 2016 Configuration menu - View commit details
-
Copy full SHA for d2e1502 - Browse repository at this point
Copy the full SHA d2e1502View commit details