Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #35826

Closed
wants to merge 26 commits into from
Closed

Rollup of 13 pull requests #35826

wants to merge 26 commits into from

Commits on Aug 17, 2016

  1. accumulate vector and assert for RangeFrom and RangeInclusive examples

    PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
    matthew-piziak committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    95c53b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. replace Add example with something more evocative of addition

    Currently most of the operator traits use trivial implementation
    examples that only perform side effects. Honestly, that might not be too
    bad for the sake of documentation; but anyway, here's a proposal to move
    a slightly modified version of the module-level point-addition example
    into the `Add` documentation, since it's more evocative of addition
    semantics.
    
    Part of rust-lang#29365
    
    wrap identifiers in backticks
    
    minor rephrasing
    
    fix module-level documentation to be more truthful
    
    This branch changes the example for `Add` to no longer be a "minimum implementation that prints something to the screen".
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    dcee93a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0dc13ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dae1406 View commit details
    Browse the repository at this point in the history
  4. Fix tiny spelling mistake in book

    Changed datastructure to data structure
    ErikUggeldahl committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    6976991 View commit details
    Browse the repository at this point in the history
  5. Add a few doc examples for std::ffi::OsStr.

    * `std::ffi::OsStr::new`.
    * `std::ffi::OsStr::is_empty`.
    * `std::ffi::OsStr::len`.
    frewsxcv committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    c2b6f72 View commit details
    Browse the repository at this point in the history
  6. Fix minor typo

    cantino committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    06302cb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    96bd6cf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    161cb36 View commit details
    Browse the repository at this point in the history
  9. note that calling drop() explicitly is a compiler error

    Part of rust-lang#29365
    
    explain that std::mem::drop in prelude will invoke Drop
    
    change "prelude" -> "the prelude"; change links to reference-style
    
    move link references to links' section
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    a516dbb View commit details
    Browse the repository at this point in the history
  10. replace AddAssign example with something more evocative of addition

    This is analogous to PR rust-lang#35709 for the `Add` trait.
    matthew-piziak committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    6c66eaa View commit details
    Browse the repository at this point in the history
  11. Update error format for E0232

    mlayne committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    39f318b View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2016

  1. Fix label messages for E0133

    wdv4758h committed Aug 19, 2016
    Configuration menu
    Copy the full SHA
    2128d31 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#35709 - matthew-piziak:add-trait-example, r…

    …=GuillaumeGomez
    
    replace `Add` example with something more evocative of addition
    
    Currently most of the operator traits use trivial implementation
    examples that only perform side effects. Honestly, that might not be too
    bad for the sake of documentation; but anyway, here's a proposal to move
    a slightly modified version of the module-level point-addition example
    into the `Add` documentation, since it's more evocative of addition
    semantics.
    
    Part of rust-lang#29365
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    39501e9 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#35710 - matthew-piziak:explicit-drop, r=ste…

    …veklabnik
    
    note that calling drop() explicitly is a compiler error
    
    Part of rust-lang#29365
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    bb03ef1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#35758 - matthew-piziak:vec-assert-over-prin…

    …tln-remaining, r=GuillaumeGomez
    
    accumulate vector and assert for RangeFrom and RangeInclusive examples
    
    PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    2f9ae0d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#35775 - frewsxcv:os-str-doc-examples, r=Gui…

    …llaumeGomez
    
    Add a few doc examples for `std::ffi::OsStr`.
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    8075826 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#35778 - clementmiao:E0395_new_error_format,…

    … r=jonathandturner
    
    updated E0395 to new error format
    
    Updated E0395 to new error format.
    Part of rust-lang#35233
    Fixes rust-lang#35693
    
    Thanks again for letting me help!
    
    r? @jonathandturner
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    e38299d View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#35780 - clementmiao:E0396_new_err_format, r…

    …=jonathandturner
    
    updated E0396 to new error format
    
    Updated E0396 to new error format.
    Part of rust-lang#35233
    Fixes rust-lang#35779
    
    Thanks again for letting me help!
    
    r? @jonathandturner
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    8c74eb6 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#35781 - ErikUggeldahl:spellingfix, r=apasel422

    Very minor spelling fix in the book
    
    Changed datastructure to data structure.
    
    r? @steveklabnik
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    46f1733 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#35793 - matthew-piziak:add-rhs-example, r=s…

    …teveklabnik
    
    demonstrate `RHS != Self` use cases for `Add` and `Sub`
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    f60bf45 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#35794 - cantino:fix-typo, r=apasel422

    Fix minor typo
    
    Minor typo in the book.
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    eb0250a View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#35804 - pliniker:master, r=jonathandturner

    Update error message for E0084
    
    Fixes rust-lang#35792 as part of rust-lang#35233
    
    r? @jonathandturner
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    20b4b99 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#35806 - matthew-piziak:addassign-example, r…

    …=steveklabnik
    
    replace `AddAssign` example with something more evocative of addition
    
    This is analogous to PR rust-lang#35709 for the `Add` trait.
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    16ce5dc View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#35812 - mlayne:E0232, r=jonathandturner

    Update error format for E0232
    
    Fixes rust-lang#35795, as part of rust-lang#35233.
    
    Excited to make my first contribution to rustc!
    
    r? @jonathandturner
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    5d18992 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#35818 - wdv4758h:E0133-label, r=Aatch

    Fix label messages for E0133
    
    Issue rust-lang#35789
    Jonathan Turner authored Aug 19, 2016
    Configuration menu
    Copy the full SHA
    d2e1502 View commit details
    Browse the repository at this point in the history