Rollup of 13 pull requests #35826
Closed
Rollup of 13 pull requests #35826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
Currently most of the operator traits use trivial implementation examples that only perform side effects. Honestly, that might not be too bad for the sake of documentation; but anyway, here's a proposal to move a slightly modified version of the module-level point-addition example into the `Add` documentation, since it's more evocative of addition semantics. Part of rust-lang#29365 wrap identifiers in backticks minor rephrasing fix module-level documentation to be more truthful This branch changes the example for `Add` to no longer be a "minimum implementation that prints something to the screen".
Changed datastructure to data structure
* `std::ffi::OsStr::new`. * `std::ffi::OsStr::is_empty`. * `std::ffi::OsStr::len`.
Part of rust-lang#29365 explain that std::mem::drop in prelude will invoke Drop change "prelude" -> "the prelude"; change links to reference-style move link references to links' section
This is analogous to PR rust-lang#35709 for the `Add` trait.
…=GuillaumeGomez replace `Add` example with something more evocative of addition Currently most of the operator traits use trivial implementation examples that only perform side effects. Honestly, that might not be too bad for the sake of documentation; but anyway, here's a proposal to move a slightly modified version of the module-level point-addition example into the `Add` documentation, since it's more evocative of addition semantics. Part of rust-lang#29365
…veklabnik note that calling drop() explicitly is a compiler error Part of rust-lang#29365
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
…llaumeGomez Add a few doc examples for `std::ffi::OsStr`.
… r=jonathandturner updated E0395 to new error format Updated E0395 to new error format. Part of rust-lang#35233 Fixes rust-lang#35693 Thanks again for letting me help! r? @jonathandturner
…=jonathandturner updated E0396 to new error format Updated E0396 to new error format. Part of rust-lang#35233 Fixes rust-lang#35779 Thanks again for letting me help! r? @jonathandturner
Very minor spelling fix in the book Changed datastructure to data structure. r? @steveklabnik
…teveklabnik demonstrate `RHS != Self` use cases for `Add` and `Sub`
Fix minor typo Minor typo in the book.
Update error message for E0084 Fixes rust-lang#35792 as part of rust-lang#35233 r? @jonathandturner
…=steveklabnik replace `AddAssign` example with something more evocative of addition This is analogous to PR rust-lang#35709 for the `Add` trait.
Update error format for E0232 Fixes rust-lang#35795, as part of rust-lang#35233. Excited to make my first contribution to rustc! r? @jonathandturner
Fix label messages for E0133 Issue rust-lang#35789
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 |
|
📌 Commit d2e1502 has been approved by |
|
⌛ Testing commit d2e1502 with merge 50df672... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
|
Rerolling... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addexample with something more evocative of addition #35709, note that calling drop() explicitly is a compiler error #35710, accumulate vector and assert for RangeFrom and RangeInclusive examples #35758, Add a few doc examples forstd::ffi::OsStr. #35775, updated E0395 to new error format #35778, updated E0396 to new error format #35780, Very minor spelling fix in the book #35781, demonstrateRHS != Selfuse cases forAddandSub#35793, Fix minor typo #35794, Update error message for E0084 #35804, replaceAddAssignexample with something more evocative of addition #35806, Update error format for E0232 #35812, Fix label messages for E0133 #35818