-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0101 and E0102 to new format #35443
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks good! And welcome aboard! 🎉 @bors r+ rollup |
📌 Commit 0e9cbf6 has been approved by |
@bors r- Oops! I just noticed one little thing. Would you mind fixing them before I send this in? |
let x = |_| {}; //~ ERROR E0101 | ||
let x = |_| {}; | ||
//~^ ERROR E0101 | ||
//~| cannot resolve type of expression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this //~| NOTE cannot resolve type of expression
instead?
Done Sir! |
Thanks! That looks good. One last thing. Can you squash your 2 commits down 1 one? With that I think it'll be ready. |
Done! 😄 |
Alright, now it looks good! @bors r+ rollup |
📌 Commit da86ae2 has been approved by |
Update E0101 and E0102 to new format Part of rust-lang#35233 Fixes rust-lang#35243 Fixes rust-lang#35244 r? @jonathandturner PS: My first contribution
Part of #35233
Fixes #35243
Fixes #35244
r? @jonathandturner
PS: My first contribution