Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0185 and E0186 to new format #35314

Merged
merged 1 commit into from
Aug 7, 2016
Merged

Update E0185 and E0186 to new format #35314

merged 1 commit into from
Aug 7, 2016

Conversation

yossi-k
Copy link
Contributor

@yossi-k yossi-k commented Aug 4, 2016 •
edited
Loading

Part of #35233.
Fixes #35277.
Fixes #35276.
r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

Looks pretty good. Question: why switch from ' to ` ?

@yossi-k
Copy link
Contributor Author

yossi-k commented Aug 4, 2016

Wow haven't even notice... That was IntelliJ.
Should I switch back?

@sophiajt
Copy link
Contributor

sophiajt commented Aug 4, 2016

Yes, please. It helps the errors be more consistent.

@yossi-k
Copy link
Contributor Author

yossi-k commented Aug 7, 2016

@jonathandturner Fixed, also added the bonus part.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Nice!

Can you squash your commits from 7 down to 1? With that I think this will be ready.

@yossi-k
Copy link
Contributor Author

yossi-k commented Aug 7, 2016

Done

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Thanks 👍

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit 6487396 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35314 - yossi-k:issue/35277, r=jonathandturner
f9f6fd4 
Update E0185 and E0186 to new format

Part of rust-lang#35233.
Fixes rust-lang#35277.
Fixes rust-lang#35276.
r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Merged
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35469 - jonathandturner:rollup, r=jonathandturner
1744c46 
Rollup of 21 pull requests

- Successful merges: #35314, #35355, #35357, #35366, #35394, #35410, #35411, #35413, #35417, #35419, #35421, #35429, #35433, #35434, #35436, #35439, #35443, #35454, #35455, #35467, #35468
- Failed merges: #35395, #35415
@bors bors merged commit 6487396 into rust-lang:master Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yossi-k @rust-highfive @sophiajt @bors