-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #34464
Merged
Merged
Rollup of 8 pull requests #34464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"boostrap" instead of "bootstrap"
E0425: unresolved name
The macro gets used to create a mapping of identifiers to names and their associated functions. Since it creates a table of language items, let's rename it in a similar manner to how vec! creates a vec.
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=10 |
📌 Commit 7db39e5 has been approved by |
⌛ Testing commit 7db39e5 with merge 21c93e5... |
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
@bors r+ p=10 force |
📌 Commit 77b6a64 has been approved by |
Improve diagnostics E0425: `use` (public) name E0425: unresolved name
Fix typo in bootstrap README "boostrap" instead of "bootstrap"
Switched tense to clarify what is happening in the example
Fix typo in future incompatible lint Found in release triage.
Indicate how the `JoinHandle` struct is created. None
…ame, r=jseyfried Renames "lets_do_this" macro more appropriately. The macro gets used to create a mapping of identifiers to names and their associated functions. Since it creates a table of language items, let's rename it in a similar manner to how vec! creates a vec.
Improve `syntax::ast::*` type docs (examples, etc) An attempt at making the public types in `syntax::ast` a bit more approachable. [#rust-doc-days](https://facility9.com/2016/06/announcing-rust-doc-days/)
bors
added a commit
that referenced
this pull request
Jun 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
(public) name #34379, Add example forstd::thread::sleep
. #34406, Fix typo in bootstrap README #34411, Switched tense to clarify what is happening in the example #34414, Fix typo in future incompatible lint #34435, Indicate how theJoinHandle
struct is created. #34438, Renames "lets_do_this" macro more appropriately. #34445, Improvesyntax::ast::*
type docs (examples, etc) #34449