Improve diagnostics E0425: use (public) name
#34379
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -843,6 +843,15 @@ Or: | |||
| let unknown_variable = 12u32; | |||
| let x = unknown_variable; // ok! | |||
| ``` | |||
|
|
|||
| Please verify that the name is declared by `use` item and ensure it's public | |||
There was a problem hiding this comment.
I'd say: "If the item isn't available in the current module, please check you imported it:".
|
@GuillaumeGomez Thank you! I've updated (and rebased). |
| bar(); | ||
| ``` | ||
|
|
||
| ...and check the item is public, non-private at least, to the current module. |
There was a problem hiding this comment.
"... and check if the item is public, non-private at least, to the current module."
There was a problem hiding this comment.
https://is.gd/8CFKu9
when use globs, rustc doesn't tells user if an item is private
There was a problem hiding this comment.
It was just because you forgot a whitespace after "...".
|
updated (and rebased) |
|
|
||
| ... and check if the item is public, non-private at least, to the current | ||
| module. | ||
|
|
There was a problem hiding this comment.
And this is an extra empty line. 😆
E0425: unresolved name
|
@nikomatsakis Thank you! Done. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 2d7bac7 has been approved by |
|
⌛ Testing commit 2d7bac7 with merge a70e068... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry On Thu, Jun 23, 2016 at 4:05 PM, bors [email protected] wrote:
|
|
⌛ Testing commit 2d7bac7 with merge 7245d2a... |
Improve diagnostics E0425: `use` (public) name E0425: unresolved name
|
⛄ The build was interrupted to prioritize another pull request. |
Improve diagnostics E0425: `use` (public) name E0425: unresolved name
E0425: unresolved name