antlr grammar verification script now compiles under latest nightly

[rozbb]

This is kind of a moving target, since none of libsyntax is stable, but at least this compiles for the time being.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[oli-obk]

maybe compiling it should be included in make check?

[rozbb]

Though I'm not certain, the impression I get from this folder is that it is
ancillary to the rest of the compiler that exists to show some theoretical
consistency that few people bother to check (I guess so because it appears
this script has been uncompilable for several months). Also it heavily
relies on an unstable API. So I'd argue that in the case that this fails to
compile in the future, it should not fail the entire make check.

On Wednesday, May 25, 2016, Oliver Schneider [email protected]
wrote:

maybe compiling it should be included in make check?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#33860 (comment)

[nagisa]

@bors r+ e8007e8

Though I'm not certain, the impression I get from this folder is that it is ancillary to the rest of the compiler that exists to show some theoretical consistency that few people bother to check

That’s about right. ANTLR tokenizer being mostly superseded by the more complete and up-to-date yacc-based grammar also contributes.

[bors]

⌛ Testing commit e8007e8 with merge 355f9e5...

[bors]

💔 Test failed - auto-linux-64-opt-rustbuild

[eddyb]

@bors retry

[rozbb]

Any idea what's causing the error? Build bug?

[bors]

⌛ Testing commit e8007e8 with merge 6e00b55...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-32cross-opt, auto-linux-64-cargotest, auto-linux-64-cross-armhf, auto-linux-64-cross-armsf, auto-linux-64-cross-freebsd, auto-linux-64-cross-netbsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-cross-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild